OLD | NEW |
---|---|
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for Chromium. | 5 """Top-level presubmit script for Chromium. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts |
8 for more details about the presubmit API built into depot_tools. | 8 for more details about the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
(...skipping 1444 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
1455 | 1455 |
1456 Whether or not a file affects IPC is determined by a simple whitelist of | 1456 Whether or not a file affects IPC is determined by a simple whitelist of |
1457 filename patterns.""" | 1457 filename patterns.""" |
1458 file_patterns = [ | 1458 file_patterns = [ |
1459 '*_messages.cc', | 1459 '*_messages.cc', |
1460 '*_messages*.h', | 1460 '*_messages*.h', |
1461 '*_param_traits*.*', | 1461 '*_param_traits*.*', |
1462 '*.mojom', | 1462 '*.mojom', |
1463 '*_struct_traits*.*', | 1463 '*_struct_traits*.*', |
1464 '*_type_converter*.*', | 1464 '*_type_converter*.*', |
1465 '*.aidl', | |
dcheng
2017/01/19 22:15:04
Nit: I probably should have done this, but mind gr
| |
1465 # Blink uses a different file naming convention | 1466 # Blink uses a different file naming convention |
1466 '*StructTraits*.*', | 1467 '*StructTraits*.*', |
1467 '*TypeConverter*.*', | 1468 '*TypeConverter*.*', |
1468 ] | 1469 ] |
1469 | 1470 |
1470 # These third_party directories do not contain IPCs, but contain files | 1471 # These third_party directories do not contain IPCs, but contain files |
1471 # matching the above patterns, which trigger false positives. | 1472 # matching the above patterns, which trigger false positives. |
1472 exclude_paths = [ | 1473 exclude_paths = [ |
1473 'third_party/crashpad/*', | 1474 'third_party/crashpad/*', |
1474 ] | 1475 ] |
(...skipping 886 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
2361 results.extend(input_api.canned_checks.CheckTreeIsOpen( | 2362 results.extend(input_api.canned_checks.CheckTreeIsOpen( |
2362 input_api, | 2363 input_api, |
2363 output_api, | 2364 output_api, |
2364 json_url='http://chromium-status.appspot.com/current?format=json')) | 2365 json_url='http://chromium-status.appspot.com/current?format=json')) |
2365 | 2366 |
2366 results.extend(input_api.canned_checks.CheckChangeHasBugField( | 2367 results.extend(input_api.canned_checks.CheckChangeHasBugField( |
2367 input_api, output_api)) | 2368 input_api, output_api)) |
2368 results.extend(input_api.canned_checks.CheckChangeHasDescription( | 2369 results.extend(input_api.canned_checks.CheckChangeHasDescription( |
2369 input_api, output_api)) | 2370 input_api, output_api)) |
2370 return results | 2371 return results |
OLD | NEW |