Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/browser/indexed_db/indexed_db_factory_unittest.cc

Issue 2642943002: Allow closing IndexedDB database before deleting (Closed)
Patch Set: Fixed compilation errors in tests Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« content/browser/indexed_db/indexed_db_factory_impl.cc ('K') | « content/browser/indexed_db/indexed_db_factory_impl.cc ('k') | content/browser/indexed_db/mock_indexed_db_factory.h » ('j') | content/child/indexed_db/webidbfactory_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/indexed_db/indexed_db_factory_unittest.cc
diff --git a/content/browser/indexed_db/indexed_db_factory_unittest.cc b/content/browser/indexed_db/indexed_db_factory_unittest.cc
index 072c9a2a0ae5b76f0c6c991c0b424a23525d71da..f89a8e2d8f035691920b5a94a8fb1bd332519e64 100644
--- a/content/browser/indexed_db/indexed_db_factory_unittest.cc
+++ b/content/browser/indexed_db/indexed_db_factory_unittest.cc
@@ -344,7 +344,7 @@ TEST_F(IndexedDBFactoryTest, DeleteDatabaseClosesBackingStore) {
scoped_refptr<MockIndexedDBCallbacks> callbacks(
new MockIndexedDBCallbacks(expect_connection));
factory()->DeleteDatabase(ASCIIToUTF16("db"), nullptr /* request_context */,
- callbacks, origin, temp_directory.GetPath());
+ callbacks, origin, temp_directory.GetPath(), false);
cmumford 2017/01/19 20:47:16 Add /* force_close */ to parameter.
eostroukhov 2017/01/20 18:43:18 Done.
EXPECT_TRUE(factory()->IsBackingStoreOpen(origin));
EXPECT_TRUE(factory()->IsBackingStorePendingClose(origin));
« content/browser/indexed_db/indexed_db_factory_impl.cc ('K') | « content/browser/indexed_db/indexed_db_factory_impl.cc ('k') | content/browser/indexed_db/mock_indexed_db_factory.h » ('j') | content/child/indexed_db/webidbfactory_impl.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698