mojo/public/tools/bindings/pylib/mojom/generate/pack.py - Issue 264293003: Adding whether a given field is filling a hole.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

Issue 264293003: Adding whether a given field is filling a hole. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/public/tools/bindings/pylib/mojom/generate/pack.py

diff --git a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

index 019fe48286edbae8090d97ae13da9fe43437f679..2b2a449cff51c7a8f854f34ca44f43296f3075a3 100644

--- a/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

+++ b/mojo/public/tools/bindings/pylib/mojom/generate/pack.py

@@ -51,6 +51,7 @@ class PackedField(object):

self.size = self.GetSizeForKind(field.kind)

self.offset = None

self.bit = None

+ self.in_hole = False

# Returns the pad necessary to reserve space for alignment of |size|.

@@ -106,6 +107,7 @@ class PackedStruct(object):

# Found hole.

src_field.offset = offset

src_field.bit = bit

+ src_field.in_hole = True

dst_fields.insert(i, src_field)

break

last_field = next_field

« no previous file with comments | « no previous file | no next file » | no next file with comments »