third_party/WebKit/Source/core/editing/SelectionController.cpp - Issue 2642913003: Select All should show handles if they were already present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/SelectionController.cpp

Issue 2642913003: Select All should show handles if they were already present (Closed)

Patch Set: forgot to change enum name in test Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/editing/SelectionController.cpp

diff --git a/third_party/WebKit/Source/core/editing/SelectionController.cpp b/third_party/WebKit/Source/core/editing/SelectionController.cpp

index 774596b2f5a31a260475f316bac27afaf479c1d2..f53db6b2ff508088d2efab96ee06f10ec3683f3a 100644

--- a/third_party/WebKit/Source/core/editing/SelectionController.cpp

+++ b/third_party/WebKit/Source/core/editing/SelectionController.cpp

@@ -680,7 +680,7 @@ void SelectionController::setNonDirectionalSelectionIfNeeded(

const FrameSelection::SetSelectionOptions options =

isHandleVisible

? FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle |

- FrameSelection::HandleVisible

+ FrameSelection::ShowHandle

: FrameSelection::CloseTyping | FrameSelection::ClearTypingStyle;

selection().setSelection(newSelection, options, CursorAlignOnScroll::IfNeeded,

« no previous file with comments | « third_party/WebKit/Source/core/editing/FrameSelectionTest.cpp ('k') | no next file » | no next file with comments »