Select All should show handles if they were already present

third_party/WebKit/Source/core/editing/FrameSelection.cpp

Index: third_party/WebKit/Source/core/editing/FrameSelection.cpp
diff --git a/third_party/WebKit/Source/core/editing/FrameSelection.cpp b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
index 0238e0b185480ab4010b2ce338dc56d0336b45ea..94190e999a465d072117843b849888eb84aab416 100644
--- a/third_party/WebKit/Source/core/editing/FrameSelection.cpp
+++ b/third_party/WebKit/Source/core/editing/FrameSelection.cpp
@@ -913,7 +913,12 @@ void FrameSelection::selectAll() {
       return;
   }
 
-  setSelection(SelectionInDOMTree::Builder().selectAllChildren(*root).build());
+  SetSelectionOptions options = CloseTyping | ClearTypingStyle;

[yosin_UTC9, 2017/01/19 08:31:03]

I prefer

const SetSelectionOptions options = isHandleVisible()
  ? CloseTypeing | ClearTyping | HandleVisible
  : CloseTypeing | ClearTyping;

[amaralp, 2017/01/20 01:22:09]

This has been removed.

+  if (isHandleVisible())

[yosin_UTC9, 2017/01/19 08:31:02]

When do we not show handle if |isHandleVisbile()|?
Can we have a option |HandleVisibleIfHahdleVisible| or another better name?
Checking |isHandleVisible()| and turn on option is very error prone.

[yosin_UTC9, 2017/01/19 09:36:52]

[1] is another example of error prone regarding handle visibility.

[1] https://codereview.chromium.org/2370663002

[amaralp, 2017/01/20 01:22:09]

A few cases I can think of:
  1) Javascript selection
  2) Tapping to clear a handle
  3) Typing should clear the handle.
Yep, |PreserveHandle| has been added.
Not sure what you mean by this. Have my new changes addressed this?

I think this change would also make changwan@'s CL simpler.

+    options |= HandleVisible;
+
+  setSelection(SelectionInDOMTree::Builder().selectAllChildren(*root).build(),
+               options);
   selectFrameElementInParentIfFullySelected();
   notifyLayoutObjectOfSelectionChange(UserTriggered);
 }