Source/modules/device_orientation/NewDeviceOrientationController.cpp - Issue 26429003: Cleanup: Add toDeviceMotionEvent and toDeviceOrientationEvent.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/device_orientation/NewDeviceOrientationController.cpp

Issue 26429003: Cleanup: Add toDeviceMotionEvent and toDeviceOrientationEvent. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Updated to ToT Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/modules/device_orientation/NewDeviceOrientationController.cpp

diff --git a/Source/modules/device_orientation/NewDeviceOrientationController.cpp b/Source/modules/device_orientation/NewDeviceOrientationController.cpp

index a9eb064c81c0424dbe8317db5df995a8f70ffacb..28d2b2690ff208eb0c6d04317e01525524d83726 100644

--- a/Source/modules/device_orientation/NewDeviceOrientationController.cpp

+++ b/Source/modules/device_orientation/NewDeviceOrientationController.cpp

@@ -89,8 +89,7 @@ void NewDeviceOrientationController::unregisterWithDispatcher()

bool NewDeviceOrientationController::isNullEvent(Event* event)

{

- ASSERT(event->type() == EventTypeNames::deviceorientation);

- DeviceOrientationEvent* orientationEvent = static_cast<DeviceOrientationEvent*>(event);

+ DeviceOrientationEvent* orientationEvent = toDeviceOrientationEvent(event);

return !orientationEvent->orientation()->canProvideEventData();

}

« no previous file with comments | « Source/modules/device_orientation/DeviceOrientationEvent.h ('k') | no next file » | no next file with comments »