Cleanup: Add toDeviceMotionEvent and toDeviceOrientationEvent.

Cleanup: Add toDeviceMotionEvent and toDeviceOrientationEvent.

Adding toDeviceMotionEvent and toDeviceOrientationEvent conversion functions to replace static_cast, and update toWheelEvent and toGestureEvent so that they accept NULL argument for consistency.
In the earlier CL, the comparison for Event.interfaceName() was being done with EventNames::<event>, which is wrong.
The interfaceName() should be compared against eventNames().interfaceForDeviceMotionEvent.

BUG=None

TEST=None; no behavior change;

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159671

[r.kasibhatla, 2013-10-10 12:51:13]

PTAL.

[Julien - ping for review, 2013-10-10 17:43:17]

In the description, the link is wrong and should be
https://codereview.chromium.org/26434002/.

What is the difference with the previous attempt at this change?

[r.kasibhatla, 2013-10-10 18:20:14]

On 2013/10/10 17:43:17, Julien Chaffraix wrote:
> In the description, the link is wrong and should be
> https://codereview.chromium.org/26434002/.
> 
> What is the difference with the previous attempt at this change?

Earlier, I was doing event->interfaceName() == EventNames::deviceorientation or
event->interfaceName() == EventNames::devicemotion.
Now, I am doing event->interfaceName() ==
eventNames().interfaceForDeviceOrientationEvent.

[tkent, 2013-10-10 21:47:12]

> Flakiness fix: Correct the assert used in DeviceMotion & DeviceOrientation. 

This is not a correct summary of this CL.
The CL summary should be same as the original one, and we had better add what
was wrong to the CL description.

[r.kasibhatla, 2013-10-11 13:25:46]

On 2013/10/10 21:47:12, tkent wrote:
> > Flakiness fix: Correct the assert used in DeviceMotion & DeviceOrientation. 
> 
> This is not a correct summary of this CL.
> The CL summary should be same as the original one, and we had better add what
> was wrong to the CL description.

Done.
I have updated the description and the also added to the description what was
fixed in this CL compared to earlier CL
(https://codereview.chromium.org/26434002/) which was causing regression in
debug builds.
PTAL.

[tkent, 2013-10-12 13:45:50]

lgtm

[commit-bot: I haz the power, 2013-10-12 13:45:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26429003/6001

[commit-bot: I haz the power, 2013-10-12 13:46:02]

Failed to apply patch for Source/core/dom/Node.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/dom/Node.cpp
  Hunk #1 FAILED at 2364.
  Hunk #2 FAILED at 2385.
  2 out of 2 hunks FAILED -- saving rejects to file Source/core/dom/Node.cpp.rej

Patch:       Source/core/dom/Node.cpp
Index: Source/core/dom/Node.cpp
diff --git a/Source/core/dom/Node.cpp b/Source/core/dom/Node.cpp
index
ff8d7dbbb0bb25966b29ee9564cd998f19924d9d..46d4cd803ea4fbb6a2bc589a8ce88fdb93df2daa
100644
--- a/Source/core/dom/Node.cpp
+++ b/Source/core/dom/Node.cpp
@@ -2364,9 +2364,10 @@ void Node::defaultEventHandler(Event* event)
         if (Page* page = document().page())
             page->contextMenuController().handleContextMenuEvent(event);
     } else if (eventType == EventTypeNames::textInput) {
-        if (event->hasInterface(eventNames().interfaceForTextEvent))
+        if (event->hasInterface(eventNames().interfaceForTextEvent)) {
             if (Frame* frame = document().frame())
-               
frame->eventHandler()->defaultTextInputEventHandler(static_cast<TextEvent*>(event));
+               
frame->eventHandler()->defaultTextInputEventHandler(toTextEvent(event));
+        }
 #if OS(WIN)
     } else if (eventType == EventTypeNames::mousedown && event->isMouseEvent())
{
         MouseEvent* mouseEvent = toMouseEvent(event);
@@ -2385,7 +2386,7 @@ void Node::defaultEventHandler(Event* event)
         }
 #endif
     } else if ((eventType == EventTypeNames::wheel || eventType ==
EventTypeNames::mousewheel) &&
event->hasInterface(eventNames().interfaceForWheelEvent)) {
-        WheelEvent* wheelEvent = static_cast<WheelEvent*>(event);
+        WheelEvent* wheelEvent = toWheelEvent(event);
 
         // If we don't have a renderer, send the wheel event to the first node
we find with a renderer.
         // This is needed for <option> and <optgroup> elements so that
<select>s get a wheel scroll.

[r.kasibhatla, 2013-10-15 05:19:50]

Updated the patch to ToT for Landing.

[commit-bot: I haz the power, 2013-10-15 14:18:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/r.kasibhatla@samsung.com/26429003/13001

[commit-bot: I haz the power, 2013-10-15 15:06:55]

Change committed as 159671