Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Unified Diff: content/renderer/mojo_context_state.cc

Issue 2642873002: Moves mojo.define -> gin.define. (Closed)
Patch Set: rebaseline Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-exception-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/mojo_context_state.cc
diff --git a/content/renderer/mojo_context_state.cc b/content/renderer/mojo_context_state.cc
index d9fa8d6b7bd285c5f328e437c2d4f672959971e6..b3b5bb24c2970943c7ea232d37953700b7614880 100644
--- a/content/renderer/mojo_context_state.cc
+++ b/content/renderer/mojo_context_state.cc
@@ -122,13 +122,13 @@ MojoContextState::MojoContextState(blink::WebFrame* frame,
->EnsureMojoBuiltinsAreAvailable(context_holder->isolate(), context);
v8::Local<v8::Object> install_target;
if (bindings_type == MojoBindingsType::FOR_LAYOUT_TESTS) {
- // In layout tests we install the module system under 'mojo.define'
+ // In layout tests we install the module system under 'gin.define'
// for now to avoid globally exposing something as generic as 'define'.
//
// TODO(rockot): Remove this if/when we can integrate gin + ES6 modules.
install_target = v8::Object::New(context->GetIsolate());
gin::SetProperty(context->GetIsolate(), context->Global(),
- gin::StringToSymbol(context->GetIsolate(), "mojo"),
+ gin::StringToSymbol(context->GetIsolate(), "gin"),
install_target);
} else {
// Otherwise we're fine installing a global 'define'.
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/dom/Geolocation/callback-exception-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698