Remove the ash-enable-touch-view-testing flag

ash/wm/maximize_mode/maximize_mode_controller_unittest.cc

Index: ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
diff --git a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
index 18f000d3229f59ed5ea38d72c9b9cde4f77a5efa..d51e82db97dd6d3c5b53e846b23cf240a402244c 100644
--- a/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
+++ b/ash/wm/maximize_mode/maximize_mode_controller_unittest.cc
@@ -445,16 +445,6 @@ TEST_F(MaximizeModeControllerTest, VerticalHingeTest) {
   }
 }
 
-// Tests that CanEnterMaximizeMode returns false until a valid accelerometer
-// event has been received, and that it returns true afterwards.
-TEST_F(MaximizeModeControllerTest,
-       CanEnterMaximizeModeRequiresValidAccelerometerUpdate) {
-  // Should be false until an accelerometer event is sent.
-  ASSERT_FALSE(maximize_mode_controller()->CanEnterMaximizeMode());
-  OpenLidToAngle(90.0f);
-  EXPECT_TRUE(maximize_mode_controller()->CanEnterMaximizeMode());

[afakhry, 2017/01/24 22:20:53]

derat@ This test doesn't make sense anymore, and hence removed. We can enter
maximized mode as long as touch view is enabled. There's no point of being able
to enter maximize mode if touch view is disabled. It makes me question the need
for |have_seen_accelerometer_data_|.

WDYT?

[Daniel Erat, 2017/01/24 22:23:28]

i don't know the full background here, but since we have a flag to enable touch
view that (i think) is set on all devices that should use touch view, i agree
that it seems much better to just use that. waiting for an accelerometer event
seems error-prone in both directions.

[afakhry, 2017/01/25 01:40:09]

I filled https://bugs.chromium.org/p/chromium/issues/detail?id=684932 to decide
the fate of that field. 

-}
-
 // Tests that when an accelerometer event is received which has no keyboard that
 // we enter maximize mode.
 TEST_F(MaximizeModeControllerTest,
@@ -541,29 +531,4 @@ TEST_F(MaximizeModeControllerTest, VerticalHingeUnstableAnglesTest) {
   }
 }
 
-class MaximizeModeControllerSwitchesTest : public MaximizeModeControllerTest {
- public:
-  MaximizeModeControllerSwitchesTest() {}
-  ~MaximizeModeControllerSwitchesTest() override {}
-
-  void SetUp() override {
-    base::CommandLine::ForCurrentProcess()->AppendSwitch(
-        switches::kAshEnableTouchViewTesting);
-    MaximizeModeControllerTest::SetUp();
-  }
-
- private:
-  DISALLOW_COPY_AND_ASSIGN(MaximizeModeControllerSwitchesTest);
-};
-
-// Tests that when the command line switch for testing maximize mode is on, that
-// accelerometer updates which would normally cause it to exit do not.
-TEST_F(MaximizeModeControllerSwitchesTest, IgnoreHingeAngles) {
-  maximize_mode_controller()->EnableMaximizeModeWindowManager(true);
-
-  // Would normally trigger an exit from maximize mode.
-  OpenLidToAngle(90.0f);
-  EXPECT_TRUE(IsMaximizeModeStarted());
-}
-
 }  // namespace ash