Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2219)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/clobber.py

Issue 2642833002: Don't clobber symlinks to build directories (Closed)
Patch Set: Disable on Windows too Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/clobber.py
diff --git a/build/clobber.py b/build/clobber.py
index 1229f7bf8d43371bd7bf089c1ef66116043f285b..b6c69982a783d45f3635eebe9ce8ca4197ffef42 100755
--- a/build/clobber.py
+++ b/build/clobber.py
@@ -37,6 +37,8 @@ def extract_gn_build_commands(build_ninja_file):
def delete_dir(build_dir):
+ if os.path.islink(build_dir):
+ return
# For unknown reasons (anti-virus?) rmtree of Chromium build directories
# often fails on Windows.
if sys.platform.startswith('win'):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698