Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(861)

Unified Diff: Source/core/rendering/RenderTable.cpp

Issue 264283002: Table with fixed layout behaves like auto layout when its width is set by js instead of css. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/fast/table/fixed-table-layout-width-change-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/RenderTable.cpp
diff --git a/Source/core/rendering/RenderTable.cpp b/Source/core/rendering/RenderTable.cpp
index b1dfd7ee6304aad949a29421810b0daa77db4f10..90f95d7b9e33a1eba02a5011611e0344fa7652fe 100644
--- a/Source/core/rendering/RenderTable.cpp
+++ b/Source/core/rendering/RenderTable.cpp
@@ -90,7 +90,7 @@ void RenderTable::styleDidChange(StyleDifference diff, const RenderStyle* oldSty
m_vSpacing = collapseBorders() ? 0 : style()->verticalBorderSpacing();
m_columnPos[0] = m_hSpacing;
- if (!m_tableLayout || style()->tableLayout() != oldTableLayout) {
+ if (!m_tableLayout || style()->tableLayout() != oldTableLayout || diff.needsFullLayout()) {
mstensho (USE GERRIT) 2014/05/06 13:28:59 It seems wrong to recreate the table layout object
if (m_tableLayout)
m_tableLayout->willChangeTableLayout();
« no previous file with comments | « LayoutTests/fast/table/fixed-table-layout-width-change-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698