Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(996)

Side by Side Diff: Source/core/rendering/style/RenderStyle.h

Issue 264283002: Table with fixed layout behaves like auto layout when its width is set by js instead of css. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Added API isTableLayoutFixed() in RenderStyle.h Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved. 5 * Copyright (C) 2003, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All r ights reserved.
6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com) 6 * Copyright (C) 2006 Graham Dennis (graham.dennis@gmail.com)
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Library General Public 9 * modify it under the terms of the GNU Library General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 545 matching lines...) Expand 10 before | Expand all | Expand 10 after
556 const Length& clipRight() const { return visual->clip.right(); } 556 const Length& clipRight() const { return visual->clip.right(); }
557 const Length& clipTop() const { return visual->clip.top(); } 557 const Length& clipTop() const { return visual->clip.top(); }
558 const Length& clipBottom() const { return visual->clip.bottom(); } 558 const Length& clipBottom() const { return visual->clip.bottom(); }
559 const LengthBox& clip() const { return visual->clip; } 559 const LengthBox& clip() const { return visual->clip; }
560 bool hasClip() const { return visual->hasClip; } 560 bool hasClip() const { return visual->hasClip; }
561 561
562 EUnicodeBidi unicodeBidi() const { return static_cast<EUnicodeBidi>(noninher ited_flags._unicodeBidi); } 562 EUnicodeBidi unicodeBidi() const { return static_cast<EUnicodeBidi>(noninher ited_flags._unicodeBidi); }
563 563
564 EClear clear() const { return static_cast<EClear>(noninherited_flags._clear) ; } 564 EClear clear() const { return static_cast<EClear>(noninherited_flags._clear) ; }
565 ETableLayout tableLayout() const { return static_cast<ETableLayout>(noninher ited_flags._table_layout); } 565 ETableLayout tableLayout() const { return static_cast<ETableLayout>(noninher ited_flags._table_layout); }
566 bool isTableLayoutFixed() const { return static_cast<ETableLayout>(noninheri ted_flags._table_layout) == TFIXED && !logicalWidth().isAuto(); }
mstensho (USE GERRIT) 2014/05/06 19:29:07 Nit: Could call tableLayout() instead.
Julien - ping for review 2014/05/07 00:35:29 Also in English, you would say "is it a fixed tabl
566 567
567 const Font& font() const; 568 const Font& font() const;
568 const FontMetrics& fontMetrics() const; 569 const FontMetrics& fontMetrics() const;
569 const FontDescription& fontDescription() const; 570 const FontDescription& fontDescription() const;
570 float specifiedFontSize() const; 571 float specifiedFontSize() const;
571 float computedFontSize() const; 572 float computedFontSize() const;
572 int fontSize() const; 573 int fontSize() const;
573 FontWeight fontWeight() const; 574 FontWeight fontWeight() const;
574 575
575 float textAutosizingMultiplier() const { return visual->m_textAutosizingMult iplier; } 576 float textAutosizingMultiplier() const { return visual->m_textAutosizingMult iplier; }
(...skipping 1299 matching lines...) Expand 10 before | Expand all | Expand 10 after
1875 inline bool RenderStyle::hasPseudoElementStyle() const 1876 inline bool RenderStyle::hasPseudoElementStyle() const
1876 { 1877 {
1877 return noninherited_flags._pseudoBits & PSEUDO_ELEMENT_MASK; 1878 return noninherited_flags._pseudoBits & PSEUDO_ELEMENT_MASK;
1878 } 1879 }
1879 1880
1880 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&); 1881 float calcBorderRadiiConstraintScaleFor(const FloatRect&, const FloatRoundedRect ::Radii&);
1881 1882
1882 } // namespace WebCore 1883 } // namespace WebCore
1883 1884
1884 #endif // RenderStyle_h 1885 #endif // RenderStyle_h
OLDNEW
« Source/core/rendering/RenderTable.cpp ('K') | « Source/core/rendering/RenderTable.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698