Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 2642823010: Tweak runtimeTypeToString for better return type inference (Closed)

Created:
3 years, 11 months ago by sra1
Modified:
3 years, 11 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Tweak runtimeTypeToString for better return type inference BUG= R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/893e2696facbbf833794dd9e31034ddc3aae49cd

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -5 lines) Patch
M sdk/lib/_internal/js_runtime/lib/js_rti.dart View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
sra1
The interpolation ensures that that branch is inferred as returning non-null String.
3 years, 11 months ago (2017-01-20 20:07:51 UTC) #2
Emily Fortuna
lgtm
3 years, 11 months ago (2017-01-20 20:10:14 UTC) #3
sra1
3 years, 11 months ago (2017-01-20 21:23:52 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
893e2696facbbf833794dd9e31034ddc3aae49cd (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698