Phase II Step 1: Remove updateImage() reentrancy around decodeError()

third_party/WebKit/Source/core/loader/resource/ImageResource.cpp

 /*
     Copyright (C) 1998 Lars Knoll (knoll@mpi-hd.mpg.de)
     Copyright (C) 2001 Dirk Mueller (mueller@kde.org)
     Copyright (C) 2002 Waldo Bastian (bastian@kde.org)
     Copyright (C) 2006 Samuel Weinig (sam.weinig@gmail.com)
     Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
 
     This library is free software; you can redistribute it and/or
     modify it under the terms of the GNU Library General Public
     License as published by the Free Software Foundation; either
@@ skipping 81 matching lines @@
     return m_resource->isAccessAllowed(securityOrigin,
                                        doesCurrentFrameHasSingleSecurityOrigin);
   }
   bool hasCacheControlNoStoreHeader() const override {
     return m_resource->hasCacheControlNoStoreHeader();
   }
   const ResourceError& resourceError() const override {
     return m_resource->resourceError();
   }
 
-  void decodeError(bool allDataReceived) override {
-    m_resource->decodeError(allDataReceived);
-  }
   void setIsPlaceholder(bool isPlaceholder) override {
     m_resource->m_isPlaceholder = isPlaceholder;
   }
   void setDecodedSize(size_t size) override {
     m_resource->setDecodedSize(size);
   }
   void willAddClientOrObserver() override {
     m_resource->willAddClientOrObserver(Resource::MarkAsReferenced);
   }
   void didRemoveClientOrObserver() override {
@@ skipping 212 matching lines @@
 }
 
 void ImageResource::decodeError(bool allDataReceived) {
   size_t size = encodedSize();
 
   clearData();
   setEncodedSize(0);
   if (!errorOccurred())
     setStatus(ResourceStatus::DecodeError);
 
+  // Finishes loading if needed, and notifies observers.
   if (!allDataReceived && loader()) {
+    // Observers are notified via ImageResource::finish().
     // TODO(hiroshige): Do not call didFinishLoading() directly.
     loader()->didFinishLoading(monotonicallyIncreasingTime(), size, size);
+  } else {
+    auto result = getContent()->updateImage(
+        nullptr, ImageResourceContent::ClearImageAndNotifyObservers,
+        allDataReceived);
+    DCHECK_EQ(result, ImageResourceContent::UpdateImageResult::NoDecodeError);
   }
 
   memoryCache()->remove(this);
 }
 
 void ImageResource::updateImageAndClearBuffer() {
   updateImage(data(), ImageResourceContent::ClearAndUpdateImage, true);
   clearData();
 }
 
@@ skipping 162 matching lines @@
 }
 
 ResourcePriority ImageResource::priorityFromObservers() {
   return getContent()->priorityFromObservers();
 }
 
 void ImageResource::updateImage(
     PassRefPtr<SharedBuffer> sharedBuffer,
     ImageResourceContent::UpdateImageOption updateImageOption,
     bool allDataReceived) {
-  getContent()->updateImage(std::move(sharedBuffer), updateImageOption,
-                            allDataReceived);
+  auto result = getContent()->updateImage(std::move(sharedBuffer),
+                                          updateImageOption, allDataReceived);
+  if (result == ImageResourceContent::UpdateImageResult::ShouldDecodeError) {
+    // In case of decode error, we call imageNotifyFinished() iff we don't
+    // initiate reloading:
+    // [(a): when this is in the middle of loading, or (b): otherwise]
+    // 1. The updateImage() call above doesn't call notifyObservers().
+    // 2. notifyObservers(ShouldNotifyFinish) is called
+    //    (a) via updateImage() called in ImageResource::finish()
+    //        called via didFinishLoading() called in decodeError(), or
+    //    (b) via updateImage() called in decodeError().
+    //    imageNotifyFinished() is called here iff we will not initiate
+    //    reloading in Step 3 due to notifyObservers()'s
+    //    schedulingReloadOrShouldReloadBrokenPlaceholder() check.
+    // 3. reloadIfLoFiOrPlaceholderImage() is called via ResourceFetcher
+    //    (a) via didFinishLoading() called in decodeError(), or
+    //    (b) after returning ImageResource::updateImage().
+    decodeError(allDataReceived);
+  }
 }
 
 }  // namespace blink