Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1302)

Unified Diff: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc

Issue 2642793005: Create a Lite Page bit for previews and fallback to Lo-Fi (Closed)
Patch Set: remove unused frame_messages.h code Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
diff --git a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
index 7ef570dc1e5584976ab19a70898f21c2296a648c..afcbb44bdb433ad56442d07b51ef0bee8f9ed276 100644
--- a/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
+++ b/components/data_reduction_proxy/core/browser/data_reduction_proxy_config.cc
@@ -969,7 +969,7 @@ bool DataReductionProxyConfig::IsEffectiveConnectionTypeSlowerThanThreshold(
effective_connection_type <= lofi_effective_connection_type_threshold_;
}
-bool DataReductionProxyConfig::ShouldEnableLoFiMode(
+bool DataReductionProxyConfig::ShouldEnableLoFi(
const net::URLRequest& request) {
DCHECK(thread_checker_.CalledOnValidThread());
DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0);
@@ -980,7 +980,7 @@ bool DataReductionProxyConfig::ShouldEnableLoFiMode(
request.context() ? request.context()->network_quality_estimator()
: nullptr;
- bool enable_lofi = ShouldEnableLoFiModeInternal(network_quality_estimator);
+ bool enable_lofi = ShouldEnableLoFiInternal(network_quality_estimator);
if (params::IsLoFiSlowConnectionsOnlyViaFlags() ||
params::IsIncludedInLoFiEnabledFieldTrial()) {
@@ -992,12 +992,23 @@ bool DataReductionProxyConfig::ShouldEnableLoFiMode(
return enable_lofi;
}
+bool DataReductionProxyConfig::ShouldEnableLitePages(
+ const net::URLRequest& request) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+ DCHECK((request.load_flags() & net::LOAD_MAIN_FRAME_DEPRECATED) != 0);
+ DCHECK(!request.url().SchemeIsCryptographic());
+
+ return ShouldEnableLitePagesInternal(
+ request.context() ? request.context()->network_quality_estimator()
+ : nullptr);
+}
+
bool DataReductionProxyConfig::enabled_by_user_and_reachable() const {
DCHECK(thread_checker_.CalledOnValidThread());
return enabled_by_user_ && !unreachable_;
}
-bool DataReductionProxyConfig::ShouldEnableLoFiModeInternal(
+bool DataReductionProxyConfig::ShouldEnableLoFiInternal(
const net::NetworkQualityEstimator* network_quality_estimator) {
DCHECK(thread_checker_.CalledOnValidThread());
@@ -1027,6 +1038,35 @@ bool DataReductionProxyConfig::ShouldEnableLoFiModeInternal(
return false;
}
+bool DataReductionProxyConfig::ShouldEnableLitePagesInternal(
+ const net::NetworkQualityEstimator* network_quality_estimator) {
+ DCHECK(thread_checker_.CalledOnValidThread());
+
+ // If Lo-Fi has been turned off, its status can't change. This Lo-Fi bit will
+ // be removed when Lo-Fi and Lite Pages are moved over to using the Previews
+ // blacklist.
+ if (lofi_off_)
+ return false;
+
+ if (params::IsLoFiAlwaysOnViaFlags() && params::AreLitePagesEnabledViaFlags())
+ return true;
+
+ if (params::IsLoFiCellularOnlyViaFlags() &&
+ params::AreLitePagesEnabledViaFlags()) {
+ return net::NetworkChangeNotifier::IsConnectionCellular(
+ net::NetworkChangeNotifier::GetConnectionType());
+ }
+
+ if ((params::IsLoFiSlowConnectionsOnlyViaFlags() &&
+ params::AreLitePagesEnabledViaFlags()) ||
+ params::IsIncludedInLitePageFieldTrial() ||
+ params::IsIncludedInLoFiControlFieldTrial()) {
+ return IsNetworkQualityProhibitivelySlow(network_quality_estimator);
+ }
+
+ return false;
+}
+
void DataReductionProxyConfig::GetNetworkList(
net::NetworkInterfaceList* interfaces,
int policy) {

Powered by Google App Engine
This is Rietveld 408576698