Move more utility functions to arc_util.

chrome/browser/chromeos/arc/arc_util.h

Index: chrome/browser/chromeos/arc/arc_util.h
diff --git a/chrome/browser/chromeos/arc/arc_util.h b/chrome/browser/chromeos/arc/arc_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..ae6ae9d598b379b1c8aa4c73b11df2c82965d409
--- /dev/null
+++ b/chrome/browser/chromeos/arc/arc_util.h
@@ -0,0 +1,23 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_
+#define CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_
+
+// Most utility should be put in components/arc/arc_util.{h,cc}, rather than
+// here. However, some utility implementation requires other modules defined in
+// chrome/, so this file contains such utilities.

[Luis Héctor Chávez, 2017/01/19 18:09:15]

nit: mention that including chrome/ from components/ is disallowed by DEPS.

[hidehiko, 2017/01/24 17:46:11]

Done.

+
+class Profile;
+
+namespace arc {
+namespace util {

[Luis Héctor Chávez, 2017/01/19 18:09:15]

I think I agree with nya@'s original comment of the util namespace being
superfluous. Only 23 *_util.h files in the codebase define an util namespace,
the vast majority (640 of them) do not.

All the utility functions currently start with "IsArc", so that's enough of a
"namespace" to prevent collisions/confusion IMO.

[hidehiko, 2017/01/24 17:46:12]

Ok, so name conflicting should be resolved now. Removed util namespace.

+
+// Returns true if Arc is allowed to run for the given profile.

[Luis Héctor Chávez, 2017/01/19 18:09:15]

nit: s/Arc/ARC/

[Yusuke Sato, 2017/01/19 22:39:31]

Can we have a little bit more documentation? Explaining when the function
returns false (in a non-comprehensive way) might be useful.

Please also mention that passing nullptr to the function is safe.

[hidehiko, 2017/01/24 17:46:12]

Done.

[hidehiko, 2017/01/24 17:46:12]

I just moved the comment ;-). Anyway, fixed.

+bool IsArcAllowedForProfile(const Profile* profile);
+
+}  // namespace util
+}  // namespace arc
+
+#endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_UTIL_H_