Move more utility functions to arc_util.

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 108 matching lines @@
       std::unique_ptr<ArcSessionRunner> arc_session_runner);
   ~ArcSessionManager() override;
 
   static ArcSessionManager* Get();
 
   // It is called from chrome/browser/prefs/browser_prefs.cc.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   static void DisableUIForTesting();
   static void SetShelfDelegateForTesting(ash::ShelfDelegate* shelf_delegate);
-
-  // Checks if OptIn verification was disabled by switch in command line.
-  static bool IsOptInVerificationDisabled();
-
   static void EnableCheckAndroidManagementForTesting();
 
-  // Returns true if Arc is allowed to run for the given profile.
-  static bool IsAllowedForProfile(const Profile* profile);
-
-  // Returns true if ARC should run under Kiosk mode.
-  static bool IsArcKioskMode();
-
   // Returns true if Arc is allowed to run for the current session.
   bool IsAllowed() const;

[Yusuke Sato, 2017/01/19 22:39:31]

I feel the function name is too similar to IsAllowedForProfile() in
c/b/c/a/arc_util.h while this one only checks if profile_ is null. Can't we
rename this to something like IsPrimaryUserProfileReady() and update the comment
at L131?

Doing this in a separate CL is fine with a TODO.

[hidehiko, 2017/01/24 17:46:11]

Sure. Added TODO.

 
   void OnPrimaryUserProfilePrepared(Profile* profile);
   void Shutdown();
 
   Profile* profile() { return profile_; }
   const Profile* profile() const { return profile_; }
 
   State state() const { return state_; }
 
   // Adds or removes observers.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Adds or removes ArcSessionObservers.
   // TODO(hidehiko): The observer should be migrated into
   // ArcSessionManager::Observer.
   void AddSessionObserver(ArcSessionObserver* observer);
   void RemoveSessionObserver(ArcSessionObserver* observer);
 
   // Returns true if ARC instance is running/stopped, respectively.
   // See ArcSessionRunner::IsRunning()/IsStopped() for details.
   bool IsSessionRunning() const;
   bool IsSessionStopped() const;
 
   // Called from Arc support platform app when user cancels signing.
   void CancelAuthCode();
 
   bool IsArcManaged() const;

[Yusuke Sato, 2017/01/19 22:39:31]

* Please document the function. When typically should we call this?
* Can we have a longer name for this, like IsArcEnabledPreferenceManaged()?

Doing this in a separate CL is fine with a TODO.

[hidehiko, 2017/01/24 17:46:11]

This is for existing code. So let me add TODO.

   bool IsArcEnabled() const;

[Yusuke Sato, 2017/01/19 22:39:31]

So we still have the function with exactly the same name as c/a/arc_util.h's
(but this one checks the pref in the profile_ rather than the command line.) Can
you at very least add function documents (on when to call this and when not) to
these the function and possibly rename it?

Doing this in a separate CL is fine with a TODO.

[hidehiko, 2017/01/24 17:46:11]

Similarly, added TODO.

[Yusuke Sato, 2017/01/24 20:36:58]

Thanks, and please fix these TODOs as part of b/3448028. The current situation
is really confusing until these TODOs are properly addressed.

 
   // This requires Arc to be allowed (|IsAllowed|)for current profile.
   void EnableArc();
   void DisableArc();
 
   // Called from the Chrome OS metrics provider to record Arc.State
   // periodically.
   void RecordArcState();
 
   // sync_preferences::PrefServiceSyncableObserver
@@ skipping 99 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_