Move more utility functions to arc_util.

chrome/browser/chromeos/arc/arc_session_manager.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 #define CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_
 
 #include <memory>
 #include <ostream>
 #include <string>
@@ skipping 108 matching lines @@
       std::unique_ptr<ArcSessionRunner> arc_session_runner);
   ~ArcSessionManager() override;
 
   static ArcSessionManager* Get();
 
   // It is called from chrome/browser/prefs/browser_prefs.cc.
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   static void DisableUIForTesting();
   static void SetShelfDelegateForTesting(ash::ShelfDelegate* shelf_delegate);
-
-  // Checks if OptIn verification was disabled by switch in command line.
-  static bool IsOptInVerificationDisabled();
-
   static void EnableCheckAndroidManagementForTesting();
 
-  // Returns true if Arc is allowed to run for the given profile.
-  static bool IsAllowedForProfile(const Profile* profile);
-
-  // Disallows ARC for all profiles for testing.
-  static void DisallowForTesting();
-
-  // Returns true if ARC should run under Kiosk mode.
-  static bool IsArcKioskMode();
-
   // Returns true if Arc is allowed to run for the current session.
+  // TODO(hidehiko): The name is very close to IsArcAllowedForProfile(), but
+  // has different meaning. Clean this up.
   bool IsAllowed() const;
 
   void OnPrimaryUserProfilePrepared(Profile* profile);
   void Shutdown();
 
   Profile* profile() { return profile_; }
   const Profile* profile() const { return profile_; }
 
   State state() const { return state_; }
 
   // Adds or removes observers.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Adds or removes ArcSessionObservers.
   // TODO(hidehiko): The observer should be migrated into
   // ArcSessionManager::Observer.
   void AddSessionObserver(ArcSessionObserver* observer);
   void RemoveSessionObserver(ArcSessionObserver* observer);
 
   // Returns true if ARC instance is running/stopped, respectively.
   // See ArcSessionRunner::IsRunning()/IsStopped() for details.
   bool IsSessionRunning() const;
   bool IsSessionStopped() const;
 
   // Called from Arc support platform app when user cancels signing.
   void CancelAuthCode();
 
+  // TODO(hidehiko): Better to rename longer but descriptive one, e.g.
+  // IsArcEnabledPreferenceManaged.
+  // TODO(hidehiko): Look at the real usage, and write document.
   bool IsArcManaged() const;
+
+  // TODO(hidehiko): better to rename longer but descriptive one, e.g.
+  // IsArcPlayStoreEnabled().
+  // TODO(hidehiko): Look at the real usage, and write document.
   bool IsArcEnabled() const;
 
   // This requires Arc to be allowed (|IsAllowed|)for current profile.
   void EnableArc();
   void DisableArc();
 
   // Called from the Chrome OS metrics provider to record Arc.State
   // periodically.
   void RecordArcState();
 
@@ skipping 100 matching lines @@
   DISALLOW_COPY_AND_ASSIGN(ArcSessionManager);
 };
 
 // Outputs the stringified |state| to |os|. This is only for logging purposes.
 std::ostream& operator<<(std::ostream& os,
                          const ArcSessionManager::State& state);
 
 }  // namespace arc
 
 #endif  // CHROME_BROWSER_CHROMEOS_ARC_ARC_SESSION_MANAGER_H_