Fix paint and rect mapping issues for stacked float under stacked inline

third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutObject.h"
 
 #include "core/frame/FrameView.h"
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutView.h"
 #include "platform/json/JSONValues.h"
@@ skipping 121 matching lines @@
       "    <div id='floating' style='float: left'>FLOAT</div>"
       "  </div>"
       "</div>");
 
   LayoutBoxModelObject* layeredDiv =
       toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
   LayoutBoxModelObject* container =
       toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
   LayoutObject* floating = getLayoutObjectByElementId("floating");
 
+  EXPECT_TRUE(container->canContainFloatingObject(*floating));
   EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
   EXPECT_EQ(layeredDiv->layer(), floating->paintingLayer());
   EXPECT_EQ(container, floating->container());
   EXPECT_EQ(container, floating->containingBlock());
 }
 
 TEST_F(LayoutObjectTest, FloatUnderInline) {
   setBodyInnerHTML(
       "<div id='layered-div' style='position: absolute'>"
       "  <div id='container'>"
-      "    <span id='layered-span' style='position: relative'>"
+      "    <span id='stacked-span' style='position: relative'>"
       "      <div id='floating' style='float: left'>FLOAT</div>"
       "    </span>"
       "  </div>"
       "</div>");
 
   LayoutBoxModelObject* layeredDiv =
       toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
   LayoutBoxModelObject* container =
       toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
-  LayoutBoxModelObject* layeredSpan =
-      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-span"));
+  LayoutBoxModelObject* stackedSpan =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("stacked-span"));
   LayoutObject* floating = getLayoutObjectByElementId("floating");
 
+  EXPECT_FALSE(stackedSpan->canContainFloatingObject(*floating));
   EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
-  EXPECT_EQ(layeredSpan->layer(), layeredSpan->paintingLayer());
+  EXPECT_EQ(stackedSpan->layer(), stackedSpan->paintingLayer());
   EXPECT_EQ(layeredDiv->layer(), floating->paintingLayer());
   EXPECT_EQ(container, floating->container());
   EXPECT_EQ(container, floating->containingBlock());
 
-  LayoutObject::AncestorSkipInfo skipInfo(layeredSpan);
+  LayoutObject::AncestorSkipInfo skipInfo(stackedSpan);
   EXPECT_EQ(container, floating->container(&skipInfo));
   EXPECT_TRUE(skipInfo.ancestorSkipped());
 
   skipInfo = LayoutObject::AncestorSkipInfo(container);
   EXPECT_EQ(container, floating->container(&skipInfo));
   EXPECT_FALSE(skipInfo.ancestorSkipped());
 }
 
+TEST_F(LayoutObjectTest, StackedFloatUnderStaticInline) {
+  setBodyInnerHTML(
+      "<div id='layered-div' style='position: absolute'>"
+      "  <div id='container'>"
+      "    <span id='span'>"
+      "      <div id='floating' style='position: relative; float: left'>F</div>"
+      "    </span>"
+      "  </div>"
+      "</div>");
+
+  LayoutBoxModelObject* layeredDiv =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
+  LayoutBoxModelObject* container =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
+  LayoutObject* span = getLayoutObjectByElementId("span");
+  LayoutBoxModelObject* floating =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("floating"));
+
+  EXPECT_FALSE(span->canContainFloatingObject(*floating));
+  EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
+  EXPECT_EQ(layeredDiv->layer(), span->paintingLayer());
+  EXPECT_EQ(floating->layer(), floating->paintingLayer());
+  EXPECT_EQ(container, floating->container());
+  EXPECT_EQ(container, floating->containingBlock());
+
+  LayoutObject::AncestorSkipInfo skipInfo(span);
+  EXPECT_EQ(container, floating->container(&skipInfo));
+  EXPECT_TRUE(skipInfo.ancestorSkipped());
+
+  skipInfo = LayoutObject::AncestorSkipInfo(container);
+  EXPECT_EQ(container, floating->container(&skipInfo));
+  EXPECT_FALSE(skipInfo.ancestorSkipped());
+}
+
+TEST_F(LayoutObjectTest, StackedFloatUnderStackedInline) {
+  setBodyInnerHTML(
+      "<div id='layered-div' style='position: absolute'>"
+      "  <div id='container'>"
+      "    <span id='stacked-span' style='position: relative'>"
+      "      <div id='floating' style='position: relative; float: left'>F</div>"
+      "    </span>"
+      "  </div>"
+      "</div>");
+
+  LayoutBoxModelObject* layeredDiv =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
+  LayoutBoxModelObject* container =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
+  LayoutBoxModelObject* stackedSpan =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("stacked-span"));
+  LayoutBoxModelObject* floating =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("floating"));
+
+  EXPECT_TRUE(stackedSpan->canContainFloatingObject(*floating));
+  EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
+  EXPECT_EQ(stackedSpan->layer(), stackedSpan->paintingLayer());
+  EXPECT_EQ(floating->layer(), floating->paintingLayer());
+  EXPECT_EQ(stackedSpan, floating->container());
+  EXPECT_EQ(container, floating->containingBlock());

[chrishtr, 2017/01/21 02:14:59]

Can you explain to me why containingBlock disagrees with
container here?

+
+  LayoutObject::AncestorSkipInfo skipInfo(stackedSpan);
+  EXPECT_EQ(stackedSpan, floating->container(&skipInfo));
+  EXPECT_FALSE(skipInfo.ancestorSkipped());
+}
+
+TEST_F(LayoutObjectTest, StackedFloatIndirectlyUnderStackedInline) {
+  setBodyInnerHTML(
+      "<div id='layered-div' style='position: absolute'>"
+      "  <div id='container'>"
+      "    <span id='stacked-span' style='opacity: 0.5'>"
+      "      <span id='span'>"
+      "        <div id='floating' style='position: relative; float: left'>"
+      "          FLOAT"
+      "        </div>"
+      "      </span>"
+      "    </span>"
+      "  </div>"
+      "</div>");
+
+  LayoutBoxModelObject* layeredDiv =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("layered-div"));
+  LayoutBoxModelObject* container =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("container"));
+  LayoutBoxModelObject* stackedSpan =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("stacked-span"));
+  LayoutObject* span = getLayoutObjectByElementId("span");
+  LayoutBoxModelObject* floating =
+      toLayoutBoxModelObject(getLayoutObjectByElementId("floating"));
+
+  EXPECT_TRUE(stackedSpan->canContainFloatingObject(*floating));
+  EXPECT_FALSE(span->canContainFloatingObject(*floating));
+  EXPECT_EQ(layeredDiv->layer(), layeredDiv->paintingLayer());
+  EXPECT_EQ(stackedSpan->layer(), stackedSpan->paintingLayer());
+  EXPECT_EQ(floating->layer(), floating->paintingLayer());
+  EXPECT_EQ(stackedSpan, floating->container());
+  EXPECT_EQ(container, floating->containingBlock());
+
+  LayoutObject::AncestorSkipInfo skipInfo(span);
+  EXPECT_EQ(stackedSpan, floating->container(&skipInfo));
+  EXPECT_TRUE(skipInfo.ancestorSkipped());
+
+  skipInfo = LayoutObject::AncestorSkipInfo(stackedSpan);
+  EXPECT_EQ(stackedSpan, floating->container(&skipInfo));
+  EXPECT_FALSE(skipInfo.ancestorSkipped());
+}
+
 TEST_F(LayoutObjectTest, MutableForPaintingClearPaintFlags) {
   LayoutObject* object = document().body()->layoutObject();
   object->setShouldDoFullPaintInvalidation();
   EXPECT_TRUE(object->shouldDoFullPaintInvalidation());
   object->m_bitfields.setChildShouldCheckForPaintInvalidation(true);
   EXPECT_TRUE(object->m_bitfields.childShouldCheckForPaintInvalidation());
   object->setMayNeedPaintInvalidation();
   EXPECT_TRUE(object->mayNeedPaintInvalidation());
   object->setMayNeedPaintInvalidationSubtree();
   EXPECT_TRUE(object->mayNeedPaintInvalidationSubtree());
@@ skipping 17 matching lines @@
   EXPECT_FALSE(object->mayNeedPaintInvalidation());
   EXPECT_FALSE(object->mayNeedPaintInvalidationSubtree());
   EXPECT_FALSE(object->mayNeedPaintInvalidationAnimatedBackgroundImage());
   EXPECT_FALSE(object->shouldInvalidateSelection());
   EXPECT_FALSE(object->backgroundChangedSinceLastPaintInvalidation());
   EXPECT_FALSE(object->needsPaintPropertyUpdate());
   EXPECT_FALSE(object->descendantNeedsPaintPropertyUpdate());
 }
 
 }  // namespace blink