third_party/WebKit/LayoutTests/http/tests/misc/resources/cross-origin-subframe-for-scrolling.html - Issue 2642723009: Improve cross-origin-subframe-for-scrolling layout test

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/misc/resources/cross-origin-subframe-for-scrolling.html

Issue 2642723009: Improve cross-origin-subframe-for-scrolling layout test (Closed)

Patch Set: Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes.html » ('j') | third_party/WebKit/LayoutTests/http/tests/misc/scroll-cross-origin-iframes.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="/js-test-resources/js-test.js"></script>	2 <script src="/js-test-resources/js-test.js"></script>
	bokan 2017/01/20 18:13:26 You can remove this I think. You can remove this I think. kenrb 2017/01/20 19:21:34 Done. Show quoted text On 2017/01/20 18:13:26, bokan wrote: > You can remove this I think. Done.
3 <div style="height: 300px"></div>	3 <div style="height: 300px"></div>

4	4

5 <script>	5 <script>

6 setPrintTestResultsLazily();	6 var port;

7 self.jsTestIsAsync = true;	7 var frame_id;

8	8

9 window.onload = (() => {	9 window.onload = (() => {

10 if (!window.eventSender \|\| !window.internals) {	10 if (!window.eventSender \|\| !window.internals) {

11 debug("This test requires window.eventSender.");	11 debug("This test requires window.eventSender.");

12 return;	12 return;

13 }	13 }

14 internals.settings.setScrollAnimatorEnabled(true);	14 internals.settings.setScrollAnimatorEnabled(true);

15 });	15 });

16	16

17 function handleMessage(event) {	17 function handleMessage(event) {

18 if (event.data.hasOwnProperty('scrollBy')) {	18 if (event.data.hasOwnProperty('scrollBy')) {

	19 port = event.source;

	20 frame_id = event.data.frame_id;

19 eventSender.mouseMoveTo(event.data.left + 5, event.data.top + 5);	21 eventSender.mouseMoveTo(event.data.left + 5, event.data.top + 5);

20 eventSender.mouseScrollBy(0, event.data.scrollBy);	22 eventSender.mouseScrollBy(0, event.data.scrollBy);

21 requestAnimationFrame(() => {setTimeout(() => {event.source.postMessage("", "*")}, 500)});

22 } else {	23 } else {

23 event.source.postMessage({scrollTop: document.documentElement.scrollTop}, "* ");	24 event.source.postMessage({scrollTop: document.documentElement.scrollTop}, "* ");

24 }	25 }

25 }	26 }

26	27

	28 window.onscroll = (() => {

	29 if (port) {

	30 port.postMessage({scrolled: frame_id}, "*");
	bokan 2017/01/20 18:13:26 Can't we simplify this and just post the scrollTop Can't we simplify this and just post the scrollTop in here?
	31 }

	32 });

	33

27 window.addEventListener("message", handleMessage);	34 window.addEventListener("message", handleMessage);

28 </script>	35 </script>

OLD	NEW