Issue 2642713002: Implement correct scope of for-in expression.

Issue 2642713002: Implement correct scope of for-in expression. (Closed)

Created:
3 years, 11 months ago by ahe

Modified:
3 years, 11 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com

Target Ref:
refs/heads/fe_integration

Visibility:
Public.

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+56 lines, -1 line)			Patch
M	pkg/dart_parser/lib/src/listener.dart	View		1 chunk	+7 lines, -0 lines	0 comments	Download
M	pkg/dart_parser/lib/src/parser.dart	View		1 chunk	+4 lines, -1 line	0 comments	Download
M	pkg/fasta/lib/src/kernel/body_builder.dart	View		1 chunk	+11 lines, -0 lines	0 comments	Download
M	pkg/fasta/test/compile.status	View	1	1 chunk	+4 lines, -0 lines	0 comments	Download
A	pkg/fasta/test/for_in_scope.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	pkg/fasta/test/for_in_scope.dart.direct.expect	View		1 chunk	+9 lines, -0 lines	0 comments	Download
A	pkg/fasta/test/for_in_scope.dart.outline.expect	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	pkg/fasta/test/kompile.status	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download

Depends on Patchset:

Dependent Patchsets:

Total messages: 9 (4 generated)

ahe

Thank you, Karl! On 2017/01/18 10:16:11, karlklose wrote: > LGTM if you add a comment ...

3 years, 11 months ago (2017-01-18 10:19:16 UTC) #6

ahe

3 years, 11 months ago (2017-01-18 15:30:00 UTC) #9

Message was sent while issue was closed.

Committed patchset #2 (id:60001) manually as
975dc28273d3892a65603094a8533725ec11f11d (presubmit successful).