Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Unified Diff: pkg/analyzer/test/generated/parser_test.dart

Issue 2642683006: Get the rest of the shared tests for covariant to pass (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analyzer/lib/src/generated/parser.dart ('k') | tests/language/language_analyzer2.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analyzer/test/generated/parser_test.dart
diff --git a/pkg/analyzer/test/generated/parser_test.dart b/pkg/analyzer/test/generated/parser_test.dart
index 06208a31405b34808a217d9e8694ccd9359c9f86..2085d19da252951d929d50dcf5b8464eea4a3e92 100644
--- a/pkg/analyzer/test/generated/parser_test.dart
+++ b/pkg/analyzer/test/generated/parser_test.dart
@@ -895,6 +895,27 @@ class ErrorParserTest extends ParserTestCase {
listener.assertErrorsWithCodes([ParserErrorCode.COVARIANT_CONSTRUCTOR]);
}
+ void test_covariantMember_getter_noReturnType() {
+ createParser('static covariant get x => 0;');
+ ClassMember member = parser.parseClassMember('C');
+ expectNotNullIfNoErrors(member);
+ listener.assertErrorsWithCodes([ParserErrorCode.COVARIANT_MEMBER]);
+ }
+
+ void test_covariantMember_getter_returnType() {
+ createParser('static covariant int get x => 0;');
+ ClassMember member = parser.parseClassMember('C');
+ expectNotNullIfNoErrors(member);
+ listener.assertErrorsWithCodes([ParserErrorCode.COVARIANT_MEMBER]);
+ }
+
+ void test_covariantMember_method() {
+ createParser('covariant int m() => 0;');
+ ClassMember member = parser.parseClassMember('C');
+ expectNotNullIfNoErrors(member);
+ listener.assertErrorsWithCodes([ParserErrorCode.COVARIANT_MEMBER]);
+ }
+
void test_covariantTopLevelDeclaration_class() {
createParser('covariant class C {}');
ClassDeclaration member =
@@ -11679,6 +11700,19 @@ void''');
expect(simpleParameter.identifier, isNotNull);
}
+ void test_parseNormalFormalParameter_simple_noType_namedCovariant() {
+ createParser('covariant)');
+ NormalFormalParameter parameter = parser.parseNormalFormalParameter();
+ expectNotNullIfNoErrors(parameter);
+ listener.assertNoErrors();
+ expect(parameter, new isInstanceOf<SimpleFormalParameter>());
+ SimpleFormalParameter simpleParameter = parameter;
+ expect(simpleParameter.covariantKeyword, isNull);
+ expect(simpleParameter.keyword, isNull);
+ expect(simpleParameter.type, isNull);
+ expect(simpleParameter.identifier, isNotNull);
+ }
+
void test_parseNormalFormalParameter_simple_type() {
createParser('A a)');
NormalFormalParameter parameter = parser.parseNormalFormalParameter();
« no previous file with comments | « pkg/analyzer/lib/src/generated/parser.dart ('k') | tests/language/language_analyzer2.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698