[wasm][asm.js] Store foreign init function for asm.js as internal field.

[wasm][asm.js] Store foreign init function for asm.js as internal field.

This avoids the foreign globals init function being visible via
GetOwnPropertyNames.

BUG=681236
R=titzer@chromium.org,aseemgarg@chromium.org

[bradnelson, 2017-01-18 08:23:47]

The CQ bit was checked by bradnelson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 08:23:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 08:50:31]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 08:50:32]

Dry run: This issue passed the CQ dry run.

[bradn, 2017-01-18 09:19:54]

bradnelson@google.com changed reviewers:
+ bradnelson@google.com

[bradn, 2017-01-18 09:19:54]

PTAL

[titzer, 2017-01-18 09:37:22]

Can't you just make this property non-enumerable, or use a private symbol
somehow?

[bradn, 2017-01-18 09:50:22]

Had wondered about using a private symbol, you have comments various places
suggesting you'd rather the brand tag is an internal field.
You prefer the private symbol?

[titzer, 2017-01-18 13:02:07]

On 2017/01/18 09:50:22, bradn wrote:
> Had wondered about using a private symbol, you have comments various places
> suggesting you'd rather the brand tag is an internal field.
> You prefer the private symbol?

I think it's worth trying a non-enumerable property first. After that, I'd
prefer the private symbol because then the exports object is less special.

[bradnelson, 2017-01-28 23:16:37]

This got fixed instead in:
https://codereview.chromium.org/2664493002/

[bradnelson, 2017-01-28 23:17:17]

Description was changed from

==========
[wasm][asm.js] Store foreign init function for asm.js as internal field.

This avoids the foreign globals init function being visible via
GetOwnPropertyNames.

BUG=681236
R=titzer@chromium.org,aseemgarg@chromium.org
==========

to

==========
[wasm][asm.js] Store foreign init function for asm.js as internal field.

This avoids the foreign globals init function being visible via
GetOwnPropertyNames.

BUG=681236
R=titzer@chromium.org,aseemgarg@chromium.org
==========

[titzer, 2017-01-29 11:59:34]

lgtm