Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: third_party/WebKit/Source/core/editing/commands/UndoStep.h

Issue 2642653002: Remove pure-virtual interface UndoStep (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/editing/commands/UndoStep.h
diff --git a/third_party/WebKit/Source/core/editing/commands/UndoStep.h b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
index 62b5eab96f6b4c3c4a215e684b11165f18c6f3a8..680a21eb36c9853dc487f4327e312a76e9109bd2 100644
--- a/third_party/WebKit/Source/core/editing/commands/UndoStep.h
+++ b/third_party/WebKit/Source/core/editing/commands/UndoStep.h
@@ -39,28 +39,18 @@ namespace blink {
class SimpleEditCommand;
-// TODO(xiaochengh): Get rid of this interface, and then rename
-// |EditCommandComposition| to |UndoStep|.
-class UndoStep : public GarbageCollectedFinalized<UndoStep> {
- public:
- virtual ~UndoStep() {}
- DEFINE_INLINE_VIRTUAL_TRACE() {}
-
- virtual void unapply() = 0;
- virtual void reapply() = 0;
- virtual InputEvent::InputType inputType() const = 0;
-};
-
-class EditCommandComposition final : public UndoStep {
+// TODO(xiaochengh): Rename this class to |UndoStep|.
+class EditCommandComposition
+ : public GarbageCollectedFinalized<EditCommandComposition> {
public:
static EditCommandComposition* create(Document*,
const VisibleSelection&,
const VisibleSelection&,
InputEvent::InputType);
- void unapply() override;
- void reapply() override;
- InputEvent::InputType inputType() const override;
+ void unapply();
+ void reapply();
+ InputEvent::InputType inputType() const;
void append(SimpleEditCommand*);
void append(EditCommandComposition*);
@@ -77,7 +67,7 @@ class EditCommandComposition final : public UndoStep {
return m_endingRootEditableElement.get();
}
- DECLARE_VIRTUAL_TRACE();
+ DECLARE_TRACE();
private:
EditCommandComposition(Document*,

Powered by Google App Engine
This is Rietveld 408576698