Remove CallWith=ScriptState from window/self/frames getters on Window.

third_party/WebKit/Source/bindings/core/v8/WindowProxyManager.h

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WindowProxyManager_h
 #define WindowProxyManager_h
 
 #include "bindings/core/v8/LocalWindowProxy.h"
 #include "bindings/core/v8/RemoteWindowProxy.h"
 #include "core/CoreExport.h"
@@ skipping 17 matching lines @@
 
   void clearForClose();
   void CORE_EXPORT clearForNavigation();
 
   void CORE_EXPORT
   releaseGlobals(HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
   void CORE_EXPORT
   setGlobals(const HashMap<DOMWrapperWorld*, v8::Local<v8::Object>>&);
 
  protected:
+  friend v8::Local<v8::Value> ToV8(WindowProxyManagerBase*,

[dcheng, 2017/01/18 07:02:00]

Since this is a temporary hack, I've opted to just expose windowProxy() here.
Eventually, I want to take this in the direction of
https://codereview.chromium.org/2630693002/, which will remove this.

+                                   v8::Local<v8::Object> creationContext,
+                                   v8::Isolate*);
+
   using IsolatedWorldMap = HeapHashMap<int, Member<WindowProxy>>;
 
   explicit WindowProxyManagerBase(Frame&);
 
   Frame* frame() const { return m_frame; }
   WindowProxy* mainWorldProxy() const { return m_windowProxy.get(); }
   WindowProxy* windowProxy(DOMWrapperWorld&);
 
   IsolatedWorldMap& isolatedWorlds() { return m_isolatedWorlds; }
 
  private:
   v8::Isolate* const m_isolate;
   const Member<Frame> m_frame;
   const Member<WindowProxy> m_windowProxy;
   IsolatedWorldMap m_isolatedWorlds;
 };
 
 template <typename FrameType, typename ProxyType>
 class WindowProxyManagerImplHelper : public WindowProxyManagerBase {
  private:
   using Base = WindowProxyManagerBase;
 
  public:
-  FrameType* frame() const { return static_cast<FrameType*>(Base::frame()); }
   ProxyType* mainWorldProxy() const {
     return static_cast<ProxyType*>(Base::mainWorldProxy());
   }
   ProxyType* windowProxy(DOMWrapperWorld& world) {
     return static_cast<ProxyType*>(Base::windowProxy(world));
   }
 
  protected:
   explicit WindowProxyManagerImplHelper(Frame& frame)
       : WindowProxyManagerBase(frame) {}
+
+  FrameType* frame() const { return static_cast<FrameType*>(Base::frame()); }

[dcheng, 2017/01/18 07:02:00]

To avoid DOMWindow from getting frame() from its window proxy manager.

 };
 
 class LocalWindowProxyManager
     : public WindowProxyManagerImplHelper<LocalFrame, LocalWindowProxy> {
  public:
   static LocalWindowProxyManager* create(LocalFrame& frame) {
     return new LocalWindowProxyManager(frame);
   }
 
   // Sets the given security origin to the main world's context.  Also updates
@@ skipping 16 matching lines @@
   }
 
  private:
   explicit RemoteWindowProxyManager(RemoteFrame& frame)
       : WindowProxyManagerImplHelper<RemoteFrame, RemoteWindowProxy>(frame) {}
 };
 
 }  // namespace blink
 
 #endif  // WindowProxyManager_h