Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 26426002: [webcrypto] Add parameters for AES-GCM and RSA-OAEP to blink API. (Closed)

Created:
7 years, 2 months ago by eroman
Modified:
7 years, 2 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, Nils Barth (inactive), jamesr, kojih, jsbell+bindings_chromium.org, dglazkov+blink, abarth-chromium, marja+watch_chromium.org, tommyw+watchlist_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, do-not-use, padolph
Visibility:
Public.

Description

[webcrypto] Add parameters for AES-GCM and RSA-OAEP to blink API. This adds definitions for AesGcmParams [1] RsaOaepParams [2]. I will add the parsing and reflection to an IDL interface in a follow-up changelist. This initial changelist just adds the public definitions, so that it can start to be used by the chromium side implementation. [1] https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#aes-gcm-params [2] https://dvcs.w3.org/hg/webcrypto-api/raw-file/tip/spec/Overview.html#dfn-RsaOaepParams BUG=245025 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159690

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -0 lines) Patch
M Source/bindings/v8/custom/V8AlgorithmCustom.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/core/platform/chromium/support/WebCryptoAlgorithm.cpp View 1 chunk +14 lines, -0 lines 0 comments Download
M Source/modules/crypto/Algorithm.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M Source/modules/crypto/NormalizeAlgorithm.cpp View 2 chunks +6 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithm.h View 4 chunks +8 lines, -0 lines 0 comments Download
M public/platform/WebCryptoAlgorithmParams.h View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
eroman
7 years, 2 months ago (2013-10-08 02:51:40 UTC) #1
abarth-chromium
lgtm
7 years, 2 months ago (2013-10-08 05:14:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/26426002/5001
7 years, 2 months ago (2013-10-12 00:19:46 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=10689
7 years, 2 months ago (2013-10-12 08:46:17 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/eroman@chromium.org/26426002/5001
7 years, 2 months ago (2013-10-15 19:02:05 UTC) #5
commit-bot: I haz the power
7 years, 2 months ago (2013-10-15 20:45:08 UTC) #6
Message was sent while issue was closed.
Change committed as 159690

Powered by Google App Engine
This is Rietveld 408576698