Relax ScopedFD close() error checking

base/files/scoped_file.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/files/scoped_file.h"
 
 #include "base/logging.h"
 #include "build/build_config.h"
 
 #if defined(OS_POSIX)
@@ skipping 17 matching lines @@
   // would make the current process keep access to a resource. Much of
   // Chrome relies on being able to "drop" such access.
   // It's especially problematic on Linux with the setuid sandbox, where
   // a single open directory would bypass the entire security model.
   int ret = IGNORE_EINTR(close(fd));
 
   // TODO(davidben): Remove this once it's been determined whether
   // https://crbug.com/603354 is caused by EBADF or a network filesystem
   // returning some other error.
   int close_errno = errno;
   base::debug::Alias(&close_errno);

[davidben, 2017/01/17 22:22:35]

We probably can just remove this. I believe we've since determined it was EBADF
and, with the change below, we won't be aliasing any useful value anyway.

 
-  PCHECK(0 == ret);
+  // NB: Some file descriptors can return errors from close() e.g. network
+  // filesystems such as NFS and Linux input devices. On Linux, errors from
+  // close other than EBADF do not indicate failure to actually close the fd.
+  PCHECK(0 == ret || close_errno != EBADF);

[Robert Sesek, 2017/01/18 03:54:41]

Since this is only a problem on Linux and not other POSIX, should we restrict
this to just OS_LINUX?

 }
 
 #endif  // OS_POSIX
 
 }  // namespace internal
 }  // namespace base