Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: tests/lib/mirrors/hierarchy_invariants_test.dart

Issue 2642443002: Support FutureOr<T> in the VM (fixes #28010). (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/hierarchy_invariants_test.dart
diff --git a/tests/lib/mirrors/hierarchy_invariants_test.dart b/tests/lib/mirrors/hierarchy_invariants_test.dart
index e35a076c0de5ada1fe38bc774c343dbe15f96fcd..e2b73cafa4e8eb7e5b384957570c76f5c78784e7 100644
--- a/tests/lib/mirrors/hierarchy_invariants_test.dart
+++ b/tests/lib/mirrors/hierarchy_invariants_test.dart
@@ -24,7 +24,9 @@ checkClass(classMirror) {
}
Expect.isTrue(classMirror.superinterfaces is List);
if (classMirror.superclass == null) {
- Expect.equals(reflectClass(Object), classMirror);
rmacnak 2017/01/17 17:58:07 I don't see why your change would affect this prop
regis 2017/01/17 18:10:20 Somehow, the mirrors implementation is using VM ty
rmacnak 2017/01/17 18:20:59 I see. LGTM w/ bug filed against this test change.
+ Expect.isTrue(classMirror == reflectClass(Object) ||
+ // Type FutureOr is mapped to dynamic in the VM.
+ classMirror.toString() == "ClassMirror on 'FutureOr'");
} else {
checkClass(classMirror.superclass);
}
« no previous file with comments | « tests/lib/lib.status ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698