Support FutureOr<T> in the VM (fixes #28010).

Support FutureOr<T> in the VM (fixes #28010).

R=asiva@google.com, rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/97c42acc3003f204abaa33bb7f09e8bd6ae7b8a0

[regis, 2017-01-17 17:14:17]

regis@google.com changed reviewers:
+ asiva@google.com, rmacnak@google.com

[rmacnak, 2017-01-17 17:58:07]

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
File tests/lib/mirrors/hierarchy_invariants_test.dart (left):

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
tests/lib/mirrors/hierarchy_invariants_test.dart:27:
Expect.equals(reflectClass(Object), classMirror);
I don't see why your change would affect this property. The superclass of
FutureOr is still Object.

[regis, 2017-01-17 18:10:20]

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
File tests/lib/mirrors/hierarchy_invariants_test.dart (left):

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
tests/lib/mirrors/hierarchy_invariants_test.dart:27:
Expect.equals(reflectClass(Object), classMirror);
On 2017/01/17 17:58:07, rmacnak wrote:
> I don't see why your change would affect this property. The superclass of
> FutureOr is still Object.

Somehow, the mirrors implementation is using VM types instead of actual classes.
This results in the classMirror for FutureOr to use the type FutureOr that has
been mapped to dynamic. The resulting classMirror is very similar to the
classMirror for dynamic, i.e it has no superclass, but its name still refers to
'FutureOr'.

[rmacnak, 2017-01-17 18:20:59]

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
File tests/lib/mirrors/hierarchy_invariants_test.dart (left):

https://codereview.chromium.org/2642443002/diff/1/tests/lib/mirrors/hierarchy...
tests/lib/mirrors/hierarchy_invariants_test.dart:27:
Expect.equals(reflectClass(Object), classMirror);
On 2017/01/17 18:10:20, regis wrote:
> On 2017/01/17 17:58:07, rmacnak wrote:
> > I don't see why your change would affect this property. The superclass of
> > FutureOr is still Object.
> 
> Somehow, the mirrors implementation is using VM types instead of actual
classes.
> This results in the classMirror for FutureOr to use the type FutureOr that has
> been mapped to dynamic. The resulting classMirror is very similar to the
> classMirror for dynamic, i.e it has no superclass, but its name still refers
to
> 'FutureOr'.

I see. LGTM w/ bug filed against this test change.

[regis, 2017-01-17 18:23:10]

Thanks!

[siva, 2017-01-17 18:25:38]

lgtm

[regis, 2017-01-17 18:27:27]

Description was changed from

==========
Support FutureOr<T> in the VM (fixes #28010).
==========

to

==========
Support FutureOr<T> in the VM (fixes #28010).

R=asiva@google.com, rmacnak@google.com

Committed:
https://github.com/dart-lang/sdk/commit/97c42acc3003f204abaa33bb7f09e8bd6ae7b8a0
==========

[regis, 2017-01-17 18:27:28]

Committed patchset #1 (id:1) manually as
97c42acc3003f204abaa33bb7f09e8bd6ae7b8a0 (presubmit successful).

[regis, 2017-01-17 18:35:50]

On 2017/01/17 18:27:28, regis wrote:
> Committed patchset #1 (id:1) manually as
> 97c42acc3003f204abaa33bb7f09e8bd6ae7b8a0 (presubmit successful).

Issue https://github.com/dart-lang/sdk/issues/28423 filed.