Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Unified Diff: src/debug.h

Issue 264233005: Clean up stack guard interrupts. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: addressed comments Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/debug.h
diff --git a/src/debug.h b/src/debug.h
index 457a5fad84bdde552813d7b30ee00b0e64795031..8fc9a08a8bd8e16f0e58a9ac7f974948f416b4b4 100644
--- a/src/debug.h
+++ b/src/debug.h
@@ -216,7 +216,6 @@ class Debug {
void Unload();
bool IsLoaded() { return !debug_context_.is_null(); }
bool InDebugger() { return thread_local_.debugger_entry_ != NULL; }
- void PreemptionWhileInDebugger();
Object* Break(Arguments args);
void SetBreakPoint(Handle<JSFunction> function,
@@ -317,18 +316,13 @@ class Debug {
}
// Check whether any of the specified interrupts are pending.
- bool is_interrupt_pending(InterruptFlag what) {
- return (thread_local_.pending_interrupts_ & what) != 0;
+ bool has_pending_interrupt() {
+ return thread_local_.has_pending_interrupt_;
}
// Set specified interrupts as pending.
- void set_interrupts_pending(InterruptFlag what) {
- thread_local_.pending_interrupts_ |= what;
- }
-
- // Clear specified interrupts from pending.
- void clear_interrupt_pending(InterruptFlag what) {
- thread_local_.pending_interrupts_ &= ~static_cast<int>(what);
+ void set_has_pending_interrupt(bool value) {
+ thread_local_.has_pending_interrupt_ = value;
}
// Getter and setter for the disable break state.
@@ -585,7 +579,7 @@ class Debug {
EnterDebugger* debugger_entry_;
// Pending interrupts scheduled while debugging.
- int pending_interrupts_;
+ bool has_pending_interrupt_;
// When restarter frame is on stack, stores the address
// of the pointer to function being restarted. Otherwise (most of the time)
« no previous file with comments | « src/arm64/regexp-macro-assembler-arm64.cc ('k') | src/debug.cc » ('j') | src/execution.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698