Clean up stack guard interrupts.

Clean up stack guard interrupts.

R=jkummerow@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=21208

[Yang, 2014-05-06 12:47:53]

please take a look.

[Jakob Kummerow, 2014-05-06 13:17:51]

LGTM with nits.

https://codereview.chromium.org/264233005/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/264233005/diff/1/src/api.cc#newcode6467
src/api.cc:6467: reinterpret_cast<i::Isolate*>(
nit: I find this line break confusing. Suggestion: pull out i_isolate like
CancelTerminateExecution below does it.

https://codereview.chromium.org/264233005/diff/1/src/debug.cc
File src/debug.cc (right):

https://codereview.chromium.org/264233005/diff/1/src/debug.cc#newcode3523
src/debug.cc:3523: // Request ebug break when leaving the last debugger entry
nit: s/ebug/debug/

[Yang, 2014-05-06 13:32:10]

On 2014/05/06 13:17:51, Jakob wrote:
> LGTM with nits.
> 
> https://codereview.chromium.org/264233005/diff/1/src/api.cc
> File src/api.cc (right):
> 
> https://codereview.chromium.org/264233005/diff/1/src/api.cc#newcode6467
> src/api.cc:6467: reinterpret_cast<i::Isolate*>(
> nit: I find this line break confusing. Suggestion: pull out i_isolate like
> CancelTerminateExecution below does it.
> 
> https://codereview.chromium.org/264233005/diff/1/src/debug.cc
> File src/debug.cc (right):
> 
> https://codereview.chromium.org/264233005/diff/1/src/debug.cc#newcode3523
> src/debug.cc:3523: // Request ebug break when leaving the last debugger entry
> nit: s/ebug/debug/

Thanks for the review. Uploaded new patch set. Landing once tree open.

[Yang, 2014-05-09 09:13:28]

Committed patchset #2 manually as r21208 (presubmit successful).

[yurys, 2014-05-29 08:42:07]

https://codereview.chromium.org/264233005/diff/20001/src/execution.cc
File src/execution.cc (right):

https://codereview.chromium.org/264233005/diff/20001/src/execution.cc#newcode735
src/execution.cc:735: ExecutionAccess access(isolate_);
Scope of this lock seems too coarse. Do we really need to hold the lock when
handling debug break? This causes a dead lock in blink when we try to terminate
worker which is running a debug loop on pause: v8::V8::TerminateExecution is
called on the main thread while ExecutionAccess lock is held on the worker
thread. Can we revert this part of the change and restore previous behavior
where the lock is only held while interrupt flags are accessed?