Source/modules/serviceworkers/Client.idl - Issue 264233003: Add blink-side binding code and tests for ServiceWorker -> Document postMessage (3/3)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: Source/modules/serviceworkers/Client.idl

Issue 264233003: Add blink-side binding code and tests for ServiceWorker -> Document postMessage (3/3) (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2014 The Chromium Authors. All rights reserved.	1 // Copyright 2014 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 [	5 [

6 Exposed=ServiceWorker,	6 Exposed=ServiceWorker,

7 RuntimeEnabled=ServiceWorker	7 RuntimeEnabled=ServiceWorker

8 ] interface Client {	8 ] interface Client {

9 readonly attribute unsigned long id;	9 readonly attribute unsigned long id;

	10 [Custom, RaisesException] void postMessage(SerializedScriptValue message, op tional MessagePort[] messagePorts);
	Inactive 2014/05/06 12:26:13 Looks like the spec says: void postMessage(any mes Looks like the spec says: void postMessage(any message, DOMString targetOrigin, optional sequence<Transferable> transfer); Aren't you missing the second mandatory argument? Or is my spec version (https://slightlyoff.github.io/ServiceWorker/spec/service_worker/) outdated? kinuko 2014/05/06 13:57:36 There's an ongoing discussion about if we really w Show quoted text On 2014/05/06 12:26:13, Chris Dumez wrote: > Looks like the spec says: > void postMessage(any message, DOMString targetOrigin, optional > sequence<Transferable> transfer); > > Aren't you missing the second mandatory argument? Or is my spec version > (https://slightlyoff.github.io/ServiceWorker/spec/service_worker/) outdated? There's an ongoing discussion about if we really want to have targetOrigin argument [1], and we suspect we do. I added a comment and link to the issue so that we can follow-up once the issue's closed. [1] https://github.com/slightlyoff/ServiceWorker/issues/190
10 };	11 };

OLD	NEW

« no previous file with comments | « Source/bindings/v8/custom/V8ClientCustom.cpp ('k') | no next file » | no next file with comments »