chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java - Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)

Patch Set: undo changes for error description Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/javatests/src/org/chromium/android_webview/test/AwWebContentsObserverTest.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ChromeTabbedActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

index 48322f396d2395525eed5a000a41130fba2bc80e..6aab0610552b9ddded47ef7fe3a76a46a579c524 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

@@ -89,12 +89,14 @@ public class ActivityTabTaskDescriptionHelper {

}

@Override

- public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,

- boolean isNavigationToDifferentPage, boolean isFragmentNavigation,

- int statusCode) {

- if (!isNavigationToDifferentPage) return;

- mLargestFavicon = null;

- updateTaskDescription();

+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,

+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,

+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,

+ int httpStatusCode) {

+ if (hasCommitted && isInMainFrame && !isSamePage) {

+ mLargestFavicon = null;

+ updateTaskDescription();

+ }

}

@Override