Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: content/browser/android/web_contents_observer_proxy.h

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: jam@ comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/web_contents_observer_proxy.h
diff --git a/content/browser/android/web_contents_observer_proxy.h b/content/browser/android/web_contents_observer_proxy.h
index 1fc84c6c968cb2b311b3156009f4980eedc54699..6b07f60fe0909b16f0fd3511000ab322e83e4c97 100644
--- a/content/browser/android/web_contents_observer_proxy.h
+++ b/content/browser/android/web_contents_observer_proxy.h
@@ -34,33 +34,16 @@ class WebContentsObserverProxy : public WebContentsObserver {
void RenderProcessGone(base::TerminationStatus termination_status) override;
void DidStartLoading() override;
void DidStopLoading() override;
- void DidFailProvisionalLoad(RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- int error_code,
- const base::string16& error_description,
- bool was_ignored_by_handler) override;
void DidFailLoad(RenderFrameHost* render_frame_host,
const GURL& validated_url,
int error_code,
const base::string16& error_description,
bool was_ignored_by_handler) override;
- void DidNavigateMainFrame(const LoadCommittedDetails& details,
- const FrameNavigateParams& params) override;
- void DidNavigateAnyFrame(RenderFrameHost* render_frame_host,
- const LoadCommittedDetails& details,
- const FrameNavigateParams& params) override;
void DocumentAvailableInMainFrame() override;
void DidFirstVisuallyNonEmptyPaint() override;
void WasShown() override;
void WasHidden() override;
void TitleWasSet(NavigationEntry* entry, bool explicit_set) override;
- void DidStartProvisionalLoadForFrame(RenderFrameHost* render_frame_host,
- const GURL& validated_url,
- bool is_error_page) override;
- void DidCommitProvisionalLoadForFrame(
- RenderFrameHost* render_frame_host,
- const GURL& url,
- ui::PageTransition transition_type) override;
void DidStartNavigation(NavigationHandle* navigation_handle) override;
void DidFinishNavigation(NavigationHandle* navigation_handle) override;
@@ -74,18 +57,8 @@ class WebContentsObserverProxy : public WebContentsObserver {
void DidAttachInterstitialPage() override;
void DidDetachInterstitialPage() override;
void DidChangeThemeColor(SkColor color) override;
- void DidStartNavigationToPendingEntry(
- const GURL& url,
- ReloadType reload_type) override;
void SetToBaseURLForDataURLIfNeeded(std::string* url);
- void DidFailLoadInternal(bool is_provisional_load,
- bool is_main_frame,
- int error_code,
- const base::string16& description,
- const GURL& url,
- bool was_ignored_by_handler);
-
base::android::ScopedJavaGlobalRef<jobject> java_observer_;
GURL base_url_of_last_started_data_url_;

Powered by Google App Engine
This is Rietveld 408576698