Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3184)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: jam@ comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
index 901b62b51f70f11bef575b192284684282548dd1..c120121a3d6632ebc591916478493c64a7e74d37 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/webapps/FullScreenActivity.java
@@ -169,12 +169,15 @@ public abstract class FullScreenActivity extends ChromeActivity {
ContentViewCore.fromWebContents(webContents).setFullscreenRequiredForOrientationLock(false);
mWebContentsObserver = new WebContentsObserver(webContents) {
@Override
- public void didCommitProvisionalLoadForFrame(
- long frameId, boolean isMainFrame, String url, int transitionType) {
- if (!isMainFrame) return;
- // Notify the renderer to permanently hide the top controls since they do
- // not apply to fullscreen content views.
- mTab.updateBrowserControlsState(mTab.getBrowserControlsStateConstraints(), true);
+ public void didFinishNavigation(String url, boolean isInMainFrame, boolean isErrorPage,
+ boolean hasCommitted, boolean isSamePage, boolean isFragmentNavigation,
+ Integer pageTransition, int errorCode, int httpStatusCode) {
+ if (hasCommitted && isInMainFrame) {
+ // Notify the renderer to permanently hide the top controls since they do
+ // not apply to fullscreen content views.
+ mTab.updateBrowserControlsState(
+ mTab.getBrowserControlsStateConstraints(), true);
+ }
}
};
}

Powered by Google App Engine
This is Rietveld 408576698