Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(731)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

Issue 2642303002: PlzNavigate: Chrome UI changes for new methods of WebContentsObserver (Closed)
Patch Set: some comments from Ted Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java b/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
index 48322f396d2395525eed5a000a41130fba2bc80e..9f580dc69d9c8faf1962befa38d204151420bd89 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java
@@ -89,10 +89,11 @@ public class ActivityTabTaskDescriptionHelper {
}
@Override
- public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,
- boolean isNavigationToDifferentPage, boolean isFragmentNavigation,
- int statusCode) {
- if (!isNavigationToDifferentPage) return;
+ public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+ boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+ boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+ int httpStatusCode) {
+ if (isSamePage) return;
mLargestFavicon = null;
updateTaskDescription();
}

Powered by Google App Engine
This is Rietveld 408576698