PlzNavigate: Chrome UI changes for new methods of WebContentsObserver

content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java

Index: content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
index 9f97f23f810dfe48d007672441057d7d73deea0c..8f6d61758dd530dcbc394587b7aae35b53051ae8 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java
@@ -132,18 +132,12 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
         }
 
         @Override
-        public void didFailLoad(boolean isProvisionalLoad, boolean isMainFrame, int errorCode,
-                String description, String failingUrl, boolean wasIgnoredByHandler) {
-            // Navigation that fails the provisional load will have the strong binding removed
-            // here. One for which the provisional load is commited will have the strong binding
-            // removed in navigationEntryCommitted() below.
-            if (isProvisionalLoad) determinedProcessVisibility();
-        }
+        public void didFinishNavigation(String url, boolean isInMainFrame, boolean isErrorPage,
+                boolean hasCommitted, boolean isSamePage, boolean isFragmentNavigation,
+                Integer pageTransition, int errorCode, int httpStatusCode) {
+            determinedProcessVisibility();

[Ted C, 2017/01/31 18:57:48]

should we do hasCommitted || errorCode != 0 to keep the logic the same as before
for this?

[shaktisahu, 2017/02/03 06:56:17]

From the comments, I think determinedProcessVisibility must to be called for
once for every navigation no matter if it fails or succeeds (I might be mistaken
though). In that case we wouldn't need to check as didFinishNavigation is
guaranteed to be called exactly once.

 
-        @Override
-        public void didNavigateMainFrame(String url, String baseUrl,
-                boolean isNavigationToDifferentPage, boolean isFragmentNavigation, int statusCode) {
-            if (!isNavigationToDifferentPage) return;
+            if (!isInMainFrame || isSamePage) return;
             resetPopupsAndInput();
         }
 
@@ -155,11 +149,6 @@ public class ContentViewCore implements AccessibilityStateChangeListener, Displa
             contentViewCore.mImeAdapter.resetAndHideKeyboard();
         }
 
-        @Override
-        public void navigationEntryCommitted() {
-            determinedProcessVisibility();
-        }
-
         private void resetPopupsAndInput() {
             ContentViewCore contentViewCore = mWeakContentViewCore.get();
             if (contentViewCore == null) return;