PlzNavigate: Chrome UI changes for new methods of WebContentsObserver

chrome/android/java/src/org/chromium/chrome/browser/ActivityTabTaskDescriptionHelper.java

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.chrome.browser;
 
 import android.graphics.Bitmap;
 import android.text.TextUtils;
 
 import org.chromium.base.ApiCompatibilityUtils;
@@ skipping 71 matching lines @@
             public void onTitleUpdated(Tab tab) {
                 updateTaskDescription();
             }
 
             @Override
             public void onSSLStateUpdated(Tab tab) {
                 if (hasSecurityWarningOrError(tab)) resetIcon();
             }
 
             @Override
-            public void onDidNavigateMainFrame(Tab tab, String url, String baseUrl,
-                    boolean isNavigationToDifferentPage, boolean isFragmentNavigation,
-                    int statusCode) {
-                if (!isNavigationToDifferentPage) return;
+            public void onDidFinishNavigation(Tab tab, String url, boolean isInMainFrame,
+                    boolean isErrorPage, boolean hasCommitted, boolean isSamePage,
+                    boolean isFragmentNavigation, Integer pageTransition, int errorCode,
+                    int httpStatusCode) {
+                if (isSamePage) return;

[jam, 2017/02/07 05:10:32]

to maintain the same behavior, you also need to check hasCommitted and
isInMainFrame

[shaktisahu, 2017/02/08 01:00:46]

Done.

                 mLargestFavicon = null;
                 updateTaskDescription();
             }
 
             @Override
             public void onLoadStopped(Tab tab, boolean toDifferentDocument) {
                 updateTaskDescription();
             }
 
             @Override
@@ skipping 160 matching lines @@
         mFaviconHelper.destroy();
 
         if (mCurrentTab != null) {
             mCurrentTab.removeObserver(mTabObserver);
         }
 
         mTabModelSelector.removeObserver(mTabModelSelectorObserver);
         mTabModelObserver.destroy();
     }
 }