CrOS - Make it possible to Alt+Tab while dragging a tab

ash/wm/window_cycle_controller_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/common/wm/window_cycle_controller.h"
 
 #include <algorithm>
 #include <memory>
 
 #include "ash/common/focus_cycler.h"
@@ skipping 632 matching lines @@
 
   // Events get through.
   generator.MoveMouseToCenterOf(w0.get());
   generator.ClickLeftButton();
   EXPECT_LT(0, event_count.GetMouseEventCountAndReset());
 
   // Start cycling.
   WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
   controller->HandleCycleWindow(WindowCycleController::FORWARD);
 
-  // Events don't get through.
-  generator.ClickLeftButton();
+  // Most mouse events don't get through.
+  generator.PressLeftButton();
   EXPECT_EQ(0, event_count.GetMouseEventCountAndReset());
 
+  // Although releases do.
+  generator.ReleaseLeftButton();
+  EXPECT_LT(0, event_count.GetMouseEventCountAndReset());
+
   // Stop cycling: once again, events get through.
   controller->CompleteCycling();
   generator.ClickLeftButton();
   EXPECT_LT(0, event_count.GetMouseEventCountAndReset());
 }
 
-// If mouse capture is lost, the UI closes.
-TEST_F(WindowCycleControllerTest, MouseCaptureLost) {
-  // This delegate allows the window to receive mouse events.
-  aura::test::TestWindowDelegate delegate;
-  std::unique_ptr<Window> w0(CreateTestWindowInShellWithDelegate(
-      &delegate, 0, gfx::Rect(0, 0, 100, 100)));
-  std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
-
-  // Start cycling.
-  WindowCycleController* controller = WmShell::Get()->window_cycle_controller();
-  controller->HandleCycleWindow(WindowCycleController::FORWARD);
-
-  // Some other widget grabs capture and this causes Alt+Tab to cease.
-  std::unique_ptr<views::Widget> widget = CreateTestWidget(
-      nullptr, kShellWindowId_DefaultContainer, gfx::Rect(1, 2, 3, 4));
-  widget->SetCapture(nullptr);
-  EXPECT_FALSE(controller->IsCycling());
-}
-
 // Tests that we can cycle past fullscreen windows: https://crbug.com/622396.
 // Fullscreen windows are special in that they are allowed to handle alt+tab
 // keypresses, which means the window cycle event filter should not handle
 // the tab press else it prevents cycling past that window.
 TEST_F(WindowCycleControllerTest, TabPastFullscreenWindow) {
   std::unique_ptr<Window> w0(CreateTestWindowInShellWithId(0));
   std::unique_ptr<Window> w1(CreateTestWindowInShellWithId(1));
   wm::WMEvent maximize_event(wm::WM_EVENT_FULLSCREEN);
 
   // To make this test work with or without the new alt+tab selector we make
@@ skipping 72 matching lines @@
     // Base case sets the expectation for other cases.
     if (expected_bounds.IsEmpty())
       expected_bounds = display_relative_bounds;
     else
       EXPECT_EQ(expected_bounds, display_relative_bounds);
     controller->CompleteCycling();
   }
 }
 
 }  // namespace ash