Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Unified Diff: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp

Issue 2642263006: Allow vibrate in cross-origin iframes with user gesture. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
diff --git a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
index 77c0ce17a2369290356d15bd872b5cb3c38f69a3..51addbc90670baf84d2bf1a3799a8cde87a8257d 100644
--- a/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
+++ b/third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp
@@ -88,8 +88,9 @@ bool NavigatorVibration::vibrate(Navigator& navigator,
"frame.");
} else {
frame->domWindow()->printErrorMessage(
- "A call of navigator.vibrate will be no-op inside cross-origin "
- "iframes: https://www.chromestatus.com/feature/5682658461876224.");
+ "A call of navigator.vibrate will be no-op inside a cross-origin "
+ "iframe if there is no user activation on the iframe: "
+ "https://www.chromestatus.com/feature/5682658461876224.");
}
return false;
}

Powered by Google App Engine
This is Rietveld 408576698