third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-vibrate-with-user-gesture-allowed.html - Issue 2642263006: Allow vibrate in cross-origin iframes with user gesture.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/resources/cross-origin-iframe-for-vibrate-with-user-gesture-allowed.html

Issue 2642263006: Allow vibrate in cross-origin iframes with user gesture. (Closed)

Patch Set: Fix test failure of enabledforall. Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/http/tests/security/vibrate_in_cross_origin_iframe_blocked.html » ('j') | third_party/WebKit/Source/modules/vibration/NavigatorVibration.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <html>

	2 <head>

	3 <script src="/resources/testharness.js"></script>

	4 <script src="/resources/testharnessreport.js"></script>

	5 <script>

	6 function loaded()

	7 {

	8 document.getElementsByTagName('h4')[0].innerHTML = document.domain;

	9 }

	10

	11 function startTest(event)

	12 {

	13 // A manual click should navigate.

	14 if (window.eventSender) {

	15 var button = document.getElementById("b");

	16 eventSender.mouseMoveTo(button.offsetLeft + event.data.x + 2, bu tton.offsetTop + event.data.y + 2);

	17 eventSender.mouseDown();

	18 eventSender.mouseUp();

	19 }

	20 }

	21

	22 function performTest()

	23 {

	24 test(function () {
	Rick Byers 2017/01/23 15:42:14 This tests that virbrate is allowed when triggered This tests that virbrate is allowed when triggered by a user gesture, but we're implementing something weaker: any time after a user gesture has occurred in the frame. To cover this can you convert it into an async test and invoke vibrate in a requestAnimationFrame callback? To be really thorough we might want to call vibrate 3 times: 1. before the mousedown 2. during the 'click' event 3. in the rAF following the click event And verify that #1 fails but #2 and #3 succeed. Off the top of my head it seems like it should be easy to do that but I might be wrong. I'll leave it up to you - min-bar for me is that we're testing case #3. Bin Lu 2017/01/23 20:18:40 Done. Show quoted text On 2017/01/23 15:42:14, Rick Byers wrote: > This tests that virbrate is allowed when triggered by a user gesture, but we're > implementing something weaker: any time after a user gesture has occurred in the > frame. To cover this can you convert it into an async test and invoke vibrate > in a requestAnimationFrame callback? > > To be really thorough we might want to call vibrate 3 times: > 1. before the mousedown > 2. during the 'click' event > 3. in the rAF following the click event > > And verify that #1 fails but #2 and #3 succeed. Off the top of my head it seems > like it should be easy to do that but I might be wrong. I'll leave it up to you > - min-bar for me is that we're testing case #3. Done.
	25 assert_true(navigator.vibrate(200));

	26 }, "A cross-origin iframe with user gesture may call navigator.vibrate .");

	27 }

	28

	29 window.addEventListener("message", startTest, false);

	30 </script>

	31 </head>

	32 <body onload="loaded();">

	33 <h4>DOMAIN</h4>

	34 <button id="b" onclick="performTest();">Perform Test</button>

	35 </body>

	36 </html>

OLD	NEW