Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(510)

Side by Side Diff: ios/web/public/web_state/web_state_delegate.h

Issue 2642233004: Removed Form Resubmission callback from CRWWebDelegate. (Closed)
Patch Set: Addressed review comments Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_ 5 #ifndef IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_
6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_ 6 #define IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_
7 7
8 #include <set> 8 #include <set>
9 9
10 #import <Foundation/Foundation.h> 10 #import <Foundation/Foundation.h>
(...skipping 21 matching lines...) Expand all
32 // |progress| is a value between 0.0 (nothing loaded) to 1.0 (page fully 32 // |progress| is a value between 0.0 (nothing loaded) to 1.0 (page fully
33 // loaded). 33 // loaded).
34 virtual void LoadProgressChanged(WebState* source, double progress); 34 virtual void LoadProgressChanged(WebState* source, double progress);
35 35
36 // Notifies the delegate that the user triggered the context menu with the 36 // Notifies the delegate that the user triggered the context menu with the
37 // given |ContextMenuParams|. Returns true if the context menu operation was 37 // given |ContextMenuParams|. Returns true if the context menu operation was
38 // handled by the delegate. 38 // handled by the delegate.
39 virtual bool HandleContextMenu(WebState* source, 39 virtual bool HandleContextMenu(WebState* source,
40 const ContextMenuParams& params); 40 const ContextMenuParams& params);
41 41
42 // Requests the repost form confirmation dialog. Clients must call |callback|
43 // with true to allow repost and with false to cancel the repost. If this
44 // method is not implemented then WebState will repost the form.
45 virtual void ShowRepostFormWarningDialog(
marq (ping after 24h) 2017/01/24 14:46:46 Naming consistency: Should this be OnFormRepostWar
Eugene But (OOO till 7-30) 2017/01/24 21:33:11 ShowRepostFormWarningDialog name matches //content
46 WebState* source,
47 const base::Callback<void(bool)>& callback);
48
42 // Returns a pointer to a service to manage dialogs. May return nullptr in 49 // Returns a pointer to a service to manage dialogs. May return nullptr in
43 // which case dialogs aren't shown. 50 // which case dialogs aren't shown.
44 // TODO(crbug.com/622084): Find better place for this method. 51 // TODO(crbug.com/622084): Find better place for this method.
45 virtual JavaScriptDialogPresenter* GetJavaScriptDialogPresenter( 52 virtual JavaScriptDialogPresenter* GetJavaScriptDialogPresenter(
46 WebState* source); 53 WebState* source);
47 54
48 // Called when a request receives an authentication challenge specified by 55 // Called when a request receives an authentication challenge specified by
49 // |protection_space|, and is unable to respond using cached credentials. 56 // |protection_space|, and is unable to respond using cached credentials.
50 // Clients must call |callback| even if they want to cancel authentication 57 // Clients must call |callback| even if they want to cancel authentication
51 // (in which case |username| or |password| should be nil). 58 // (in which case |username| or |password| should be nil).
(...skipping 16 matching lines...) Expand all
68 // Called when |this| is no longer the WebStateDelegate for |source|. 75 // Called when |this| is no longer the WebStateDelegate for |source|.
69 void Detach(WebState* source); 76 void Detach(WebState* source);
70 77
71 // The WebStates for which |this| is currently a delegate. 78 // The WebStates for which |this| is currently a delegate.
72 std::set<WebState*> attached_states_; 79 std::set<WebState*> attached_states_;
73 }; 80 };
74 81
75 } // namespace web 82 } // namespace web
76 83
77 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_ 84 #endif // IOS_WEB_PUBLIC_WEB_STATE_WEB_STATE_DELEGATE_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698