Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(722)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2642213005: [Payments] Add CanMakePayment metrics. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index 15e0acb6c1721e815f6d451db8fbd9aff28c53ea..026ff3dae231e075bb9735aaf95b0302bd5b9563 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -479,6 +479,7 @@ public class PaymentRequestImpl
mUI.show();
recordSuccessFunnelHistograms("Shown");
+ mJourneyLogger.setShowCalled();
}
private static Map<String, PaymentMethodData> getValidatedMethodData(
@@ -1148,12 +1149,16 @@ public class PaymentRequestImpl
}
query.addObserver(this);
- if (isFinishedQueryingPaymentApps()) query.setResponse(mCanMakePayment);
+ if (isFinishedQueryingPaymentApps()) {
+ query.setResponse(mCanMakePayment);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
+ }
}
private void respondCanMakePaymentQuery(boolean response) {
mClient.onCanMakePayment(response ? CanMakePaymentQueryResult.CAN_MAKE_PAYMENT
: CanMakePaymentQueryResult.CANNOT_MAKE_PAYMENT);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
if (sObserverForTest != null) {
sObserverForTest.onPaymentRequestServiceCanMakePaymentQueryResponded();
}

Powered by Google App Engine
This is Rietveld 408576698