Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2642213005: [Payments] Add CanMakePayment metrics. (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
index f282bc76ac34554686194736b208c72debeccb0f..73b10d905993cf3791c0e52c44dfc27acf13a304 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java
@@ -501,6 +501,7 @@ public class PaymentRequestImpl
if (!mShouldSkipShowingPaymentRequestUi) mUI.show();
recordSuccessFunnelHistograms("Shown");
+ mJourneyLogger.setShowCalled();
triggerPaymentAppUiSkipIfApplicable();
}
@@ -1188,12 +1189,16 @@ public class PaymentRequestImpl
}
query.addObserver(this);
- if (isFinishedQueryingPaymentApps()) query.setResponse(mCanMakePayment);
+ if (isFinishedQueryingPaymentApps()) {
+ query.setResponse(mCanMakePayment);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
+ }
}
private void respondCanMakePaymentQuery(boolean response) {
mClient.onCanMakePayment(response ? CanMakePaymentQueryResult.CAN_MAKE_PAYMENT
: CanMakePaymentQueryResult.CANNOT_MAKE_PAYMENT);
+ mJourneyLogger.setCanMakePaymentValue(mCanMakePayment);
if (sObserverForTest != null) {
sObserverForTest.onPaymentRequestServiceCanMakePaymentQueryResponded();
}
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestJourneyLogger.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698