Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 26422003: [Android] Launch chrome using an intent before running uiautomator tests. (Closed)

Created:
7 years, 2 months ago by frankf
Modified:
7 years, 2 months ago
Reviewers:
craigdh
CC:
chromium-reviews, craigdh+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org, klundberg+watch_chromium.org, frankf+watch_chromium.org
Visibility:
Public.

Description

[Android] Launch chrome using an intent before running uiautomator tests. Also use PACKAGE_INFO constants for specifying the package under test. BUG=None R=craigdh@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=227535

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -34 lines) Patch
M build/android/pylib/monkey/test_options.py View 1 chunk +1 line, -2 lines 0 comments Download
M build/android/pylib/monkey/test_runner.py View 4 chunks +18 lines, -15 lines 0 comments Download
M build/android/pylib/uiautomator/test_options.py View 1 chunk +1 line, -1 line 0 comments Download
M build/android/pylib/uiautomator/test_runner.py View 3 chunks +9 lines, -2 lines 1 comment Download
M build/android/test_runner.py View 6 chunks +20 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
frankf
7 years, 2 months ago (2013-10-08 02:27:08 UTC) #1
craigdh
lgtm w/ question https://codereview.chromium.org/26422003/diff/1/build/android/pylib/uiautomator/test_runner.py File build/android/pylib/uiautomator/test_runner.py (right): https://codereview.chromium.org/26422003/diff/1/build/android/pylib/uiautomator/test_runner.py#newcode64 build/android/pylib/uiautomator/test_runner.py:64: self.adb.StartActivity(self._package, How was this being started ...
7 years, 2 months ago (2013-10-08 16:57:49 UTC) #2
craigdh
On 2013/10/08 16:57:49, craigdh wrote: > lgtm w/ question > > https://codereview.chromium.org/26422003/diff/1/build/android/pylib/uiautomator/test_runner.py > File build/android/pylib/uiautomator/test_runner.py ...
7 years, 2 months ago (2013-10-08 17:12:06 UTC) #3
frankf
7 years, 2 months ago (2013-10-08 17:29:36 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r227535 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698