Issue 2642133003: Revert "Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks regist…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2642133003: Revert "Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks regist… (Closed)

Created:
3 years, 11 months ago by bkonyi

Modified:
3 years, 11 months ago

Reviewers:
zra

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project."" This reverts commit 10686766cddb600319820aa31aff42ef82118aee. BUG= TBR=zra@google.com

Patch Set 1 #

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+499 lines, -11 lines)			Patch
M	runtime/BUILD.gn	View	2 chunks	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/BUILD.gn	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/bin/gen_snapshot.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View	3 chunks	+3 lines, -1 line	0 comments	Download
M	runtime/vm/hash_map.h	View	2 chunks	+57 lines, -0 lines	0 comments	Download
M	runtime/vm/hash_map_test.cc	View	2 chunks	+61 lines, -0 lines	0 comments	Download
M	runtime/vm/malloc_hooks.h	View	1 chunk	+7 lines, -1 line	0 comments	Download
M	runtime/vm/malloc_hooks.cc	View	1 chunk	+251 lines, -4 lines	0 comments	Download
A	runtime/vm/malloc_hooks_test.cc	View	1 chunk	+80 lines, -0 lines	0 comments	Download
M	runtime/vm/malloc_hooks_unsupported.cc	View	1 chunk	+25 lines, -3 lines	0 comments	Download
M	runtime/vm/vm_sources.gypi	View	1 chunk	+2 lines, -1 line	0 comments	Download

Depends on Patchset:

Issue 2644183002 Patch 1