Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1914)

Unified Diff: net/spdy/spdy_stream_unittest.cc

Issue 2642133002: Change WeakPtr<SpdyStream> to raw pointer in SpdyHttpStream. (Closed)
Patch Set: Nits. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/spdy/spdy_stream.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/spdy/spdy_stream_unittest.cc
diff --git a/net/spdy/spdy_stream_unittest.cc b/net/spdy/spdy_stream_unittest.cc
index 9f60908a9b6bfaff4afa0833c8fff4fce999b9c3..495b7d40bb0c2582e18e20431944b101c7d88ee1 100644
--- a/net/spdy/spdy_stream_unittest.cc
+++ b/net/spdy/spdy_stream_unittest.cc
@@ -343,7 +343,7 @@ TEST_F(SpdyStreamTest, PushedStream) {
data.RunUntilPaused();
- base::WeakPtr<SpdyStream> push_stream;
+ SpdyStream* push_stream;
EXPECT_THAT(session->GetPushStream(GURL(kPushUrl), IDLE, &push_stream,
NetLogWithSource()),
IsOk());
@@ -355,7 +355,7 @@ TEST_F(SpdyStreamTest, PushedStream) {
EXPECT_EQ(g_time_now, load_timing_info.push_start);
EXPECT_TRUE(load_timing_info.push_end.is_null());
- StreamDelegateDoNothing push_delegate(push_stream);
+ StreamDelegateDoNothing push_delegate(push_stream->GetWeakPtr());
push_stream->SetDelegate(&push_delegate);
data.Resume();
@@ -656,7 +656,7 @@ TEST_F(SpdyStreamTest, UpperCaseHeadersOnPush) {
data.RunUntilPaused();
- base::WeakPtr<SpdyStream> push_stream;
+ SpdyStream* push_stream;
EXPECT_THAT(session->GetPushStream(GURL(kPushUrl), IDLE, &push_stream,
NetLogWithSource()),
IsOk());
« no previous file with comments | « net/spdy/spdy_stream.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698