Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: net/spdy/spdy_session.h

Issue 2642133002: Change WeakPtr<SpdyStream> to raw pointer in SpdyHttpStream. (Closed)
Patch Set: Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/spdy/spdy_session.h
diff --git a/net/spdy/spdy_session.h b/net/spdy/spdy_session.h
index 6bdb5fcaf2420375d2bc4e0e7703c0dc0ac35ff0..1e3244e3fecf5d3b7fad349e6fdc6083b39e80ce 100644
--- a/net/spdy/spdy_session.h
+++ b/net/spdy/spdy_session.h
@@ -327,7 +327,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// of that stream is updated to match |priority|.
int GetPushStream(const GURL& url,
RequestPriority priority,
- base::WeakPtr<SpdyStream>* spdy_stream,
+ SpdyStream** spdy_stream,
const NetLogWithSource& stream_net_log);
// Called when the pushed stream should be cancelled. If the pushed stream is
@@ -818,7 +818,7 @@ class NET_EXPORT SpdySession : public BufferedSpdyFramerVisitorInterface,
// Check if we have a pending pushed-stream for this url
// Returns the stream if found (and returns it from the pending
// list). Returns NULL otherwise.
- base::WeakPtr<SpdyStream> GetActivePushStream(const GURL& url);
+ SpdyStream* GetActivePushStream(const GURL& url);
void RecordPingRTTHistogram(base::TimeDelta duration);
void RecordHistograms();

Powered by Google App Engine
This is Rietveld 408576698