Change WeakPtr<SpdyStream> to raw pointer in SpdyHttpStream.

net/spdy/spdy_http_stream.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_HTTP_STREAM_H_
 #define NET_SPDY_SPDY_HTTP_STREAM_H_
 
 #include <stdint.h>
 
 #include <list>
@@ skipping 18 matching lines @@
 
 // The SpdyHttpStream is a HTTP-specific type of stream known to a SpdySession.
 class NET_EXPORT_PRIVATE SpdyHttpStream : public SpdyStream::Delegate,
                                           public MultiplexedHttpStream {
  public:
   static const size_t kRequestBodyBufferSize;
   // |spdy_session| must not be NULL.
   SpdyHttpStream(const base::WeakPtr<SpdySession>& spdy_session, bool direct);
   ~SpdyHttpStream() override;
 
-  SpdyStream* stream() { return stream_.get(); }
+  SpdyStream* stream() { return stream_; }
 
   // Cancels any callbacks from being invoked and deletes the stream.
   void Cancel();
 
   // HttpStream implementation.
 
   int InitializeStream(const HttpRequestInfo* request_info,
                        RequestPriority priority,
                        const NetLogWithSource& net_log,
                        const CompletionCallback& callback) override;
@@ skipping 71 matching lines @@
   // Call the user callback associated with reading the response.
   void DoResponseCallback(int rv);
 
   void ScheduleBufferedReadCallback();
   void DoBufferedReadCallback();
   bool ShouldWaitForMoreBufferedData() const;
 
   const base::WeakPtr<SpdySession> spdy_session_;
   bool is_reused_;
   SpdyStreamRequest stream_request_;
-  base::WeakPtr<SpdyStream> stream_;
+  SpdyStream* stream_;

[xunjieli, 2017/01/20 02:57:20]

Can you add a comment here on who owns |stream_| and when the pointer is
guaranteed to be valid (e.g. after InitializeStream() and before
Delegate::OnClose()).

[Bence, 2017/01/20 15:53:13]

Done.  Also added a comment for |stream_closed_| once we are here.

 
   bool stream_closed_;
 
   // Set only when |stream_closed_| is true.
   int closed_stream_status_;
   SpdyStreamId closed_stream_id_;
   bool closed_stream_has_load_timing_info_;
   LoadTimingInfo closed_stream_load_timing_info_;
   // After |stream_| has been closed, this keeps track of the total number of
   // bytes received over the network for |stream_| while it was open.
@@ skipping 43 matching lines @@
   bool was_alpn_negotiated_;
 
   base::WeakPtrFactory<SpdyHttpStream> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(SpdyHttpStream);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_HTTP_STREAM_H_