Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(82)

Unified Diff: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html

Issue 2642123003: Bluetooth: Make maximum possible name filter 248 bytes, not 240 (Closed)
Patch Set: Change all NotFoundErrors to TypeErrors Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
diff --git a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
index 0ec1edba051fafe63b5eb5288031e69bdcf8258e..de430b30bbe7b3974add3a7bee6b421c4b6ecd24 100644
--- a/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
+++ b/third_party/WebKit/LayoutTests/bluetooth/requestDevice/canonicalizeFilter/unicode-max-length-for-device-name-name.html
@@ -5,16 +5,14 @@
<script>
promise_test(() => {
// \u2764's UTF-8 respresentation is 3 bytes long.
- // 81 chars * 3 bytes/char = 243 bytes
- const unicode_name = generate_string(81, '\u2764');
+ // 83 chars * 3 bytes/char = 249 bytes
+ const unicode_name = generate_string(83, '\u2764');
return assert_promise_rejects_with_message(
requestDeviceWithKeyDown({filters: [{name: unicode_name}]}),
new DOMException(
'Failed to execute \'requestDevice\' on \'Bluetooth\': ' +
- 'A \'name\' or \'namePrefix\' longer than 240 bytes ' +
- 'results in no devices being found, because a device can\'t ' +
- 'acquire a name longer than 240 bytes.',
- 'NotFoundError'));
-}, 'Unicode string with utf8 representation between (240, 248] bytes in ' +
- '\'name\' must throw NotFoundError.');
+ 'A device name can\'t be longer than 248 bytes.',
+ 'TypeError'));
+}, 'Unicode string with utf8 representation longer than 248 bytes in ' +
+ '\'name\' must throw TypeError.');
</script>

Powered by Google App Engine
This is Rietveld 408576698